[2.3] Database Media Storage - Transactional Emails will now extract image from database in Database Media Storage mode

[gwharton]

Description (*)

If the email logo does not exist in pub/media and we are in database storage mode, then magento should copy the image file from database to local pub/media prior to continuing.

Fixed Issues (if relevant)

1. Database Media Storage - Transaction emails logo not used when pub/media cleared #21671: Database Media Storage - Transaction emails logo not used when pub/media cleared

Manual testing scenarios (*)

1. Setup Magento
2. Change media storage mode to database
3. Synchronize
4. Save Settings
5. Set store General Contact email address to valid email
6. Set email logo (Content->Configuration->Edit->Transactional Emails)
7. Clear Cache
8. Verify email logo exists in database <- This will fail on 2.3-develop due to Database Media Storage - Design Config fails to save transactional email logo correctly #21672
9. Verify email logo exists in pub/media
10. On Frontend, subscribe to newsletter
11. Verify newsletter email contains logo
12. Clear pub/media, simulating a new cluster node being used
13. On Frontend, subscribe to newsletter (need to use new email address, or delete 1st address in backend first)
14. Verify newsletter email contains logo

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[gwharton]

Hold pending resolution to #21672, otherwise difficult to reproduce in isolation and prove.

[ghost]

@gwharton unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-4828 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[gwharton]

@Nazar65 As stated in the bug description, it is difficult to verify and test this fix without the fix for #21672 in place. The fix for #21672 has now been merged into 2.2-develop and 2.3-develop, therefore if you would like me to bring this PR up to date by merging in the respective development branch so that it can be properly tested with the #21672 fix in place, then please let me know. I have avoided doing this thus far as this PR seems to have progressed beyond the testing phase and into the merging phase and I didn't want to play a last minute swerve ball.

[Nazar65]

hi @gwharton , thanks, but seems like everything is ok, just wait when this pr will be merged.

[m2-assistant]

Hi @gwharton, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.