Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable

[sprankhub]

Description (*)

When developing backend forms with the help of backend UI components, the Magento\Ui\DataProvider\AbstractDataProvider comes in handy. One can simply inherit from it, set one's own collection in the constructor and one could be done. However, in practice, it does not work this way, because Magento\Ui\Component\Form::getDataSourceData relies on the fact that the related entity has an id_field_name property. Since this is mostly not the case, one gets the following notice:

Notice: Undefined index: id_field_name in /var/www/magento2/vendor/magento/module-ui/Component/Form.php on line 77

Since one needs to define the primary field name in the data provider XML config anyway, it should be much more robust to get the primary field name from there. It is already used in the filter anyway.

Fixed Issues (if relevant)

1. n/a

Manual testing scenarios (*)

1. Create a custom backend UI component form.
2. Implement a data provider, which inherits from Magento\Ui\DataProvider\AbstractDataProvider and simply sets a custom collection in the constructor, e.g. a simple order collection of type Magento\Sales\Model\ResourceModel\Order\Collection.
3. Open the UI component in the backend in developer mode.
4. See the notice quoted above.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @sprankhub. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[swnsma]

Hi @sprankhub,
Could I ask you to cover current method with unit tests?

[sprankhub]

@swnsma I will try :-)

[sprankhub]

@swnsma I added a unit test now, which fails without this PR and passes with it.

[swnsma]

Hi @sprankhub,
Thanks!

Could you please check your last commit? It seems to be authored by git user(email) which not related to your current account. You can change commit author with force-push.

[sprankhub]

No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(

Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

[nilesh2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (267/250 (106%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o10.sgmail.github.com ([167.89.101.201]:43430) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohv-000F3S-4z for [email protected]; Thu, 21 Feb 2019 13:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=YRZyzCM2/FBmfQQk9q/S2vTS/w0=; b=UQ0qJEFLe+myvVqk UqQ2rvlmimi3bWZ2kfRc8aVaRHj3oBlVomETqWNyIPmNDZd0tWKjqUG5kTka0rdo OZGlD6uDNRty3oAFK4zeW+B7O4nC5ZDpVmVewxj1W9La9NODWTSdSu9fITSHJ4Q0 o0w0Z06nYM7ZA+UjPP9+HwtZZnM= Received: by filter0357p1iad2.sendgrid.net with SMTP id filter0357p1iad2-7997-5C6EABF0-39 2019-02-21 13:47:28.859503912 +0000 UTC m=+231838.148350452 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id jy4USO2hTqS-pIBIDgAVjA for <[email protected]>; Thu, 21 Feb 2019 13:47:28.856 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id CBB9C3E11A3 for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: nilesh2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+01147802541d1ab8b334eed29027c2d1a559f23aae55242692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR4Av0T-tgV1azH4-0sVLCyv17X38Rrks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: w4I78YjotwlhC+uMz5F/zn+z+PWWXH1Np2hyvsk6OD+qVW+dubn7tUXoRev8SKSUhV0zafemmf3eFi 7JM9z25NmqP0XyZsUl7F8BtUx1MMvQ1C0mhRtdqBOq+NUP0bNhL9zdu0V7RDsBWBqPoY+TioisIAcw jCkxhBB/rnPBk+2cedvQeiszGeNIuAwRm+flm9EZn4AKvuKzk4nio3clDh2QV/6c+senw16cIA/zVs Y=

----==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR4AiVqFymUSZjymmLYzaMhudvBHnJgks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR4ArR2QFJ61z9CSxO-pohyPm4UNuCNks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21065 (comment)", "url": "#21065 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d--

[ajay2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (262/250 (104%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from out-14.smtp.github.com ([192.30.254.197]:55989) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3T-AB for [email protected]; Thu, 21 Feb 2019 13:48:10 +0000 Date: Thu, 21 Feb 2019 05:47:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756848; bh=WcXbZtkkfPcbJk3izbkTJt6OAzUesRnCyzbl3WUhHKE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WEG592Nq5S+inATAoKyeP3SX7Ax67OyS0DQruQw4ujl+zm8u2tiz7CNlwu0V2iguR AhQhEySri89cl7NlF8Hue2Fn9kwRK4ZJwjuf+bY54zoMwI4M6LcI/WyCYrJPnZbNfr BxwSM2Mev+wqQEvuEVJewBT7nX74APwjc/6whmiA= From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: ajay2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011477aaa4cfc1921cc9bead078c4bf86818a3c30f5d320692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3qtjhschw5MPrqu3EpcPS7aQQWHR0ks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR3qnaX6RjVhdJCDvxlhqUuSdBpT7UFks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR3qt1WT1hVai9dOhlbYXCq1PEQVZJhks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21065 (comment)", "url": "#21065 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771--

[priti2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (266/250 (106%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o4.sgmail.github.com ([192.254.112.99]:53462) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohv-000F3U-5X for [email protected]; Thu, 21 Feb 2019 13:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=yrRQOj7m+tN1iA+N7MX6G8Ekabg=; b=n806nTAv7MoeFBVJ 6D8uTPdb1K4sqjEdksDA784TJYv9Mc6LMBiPUUNn4ANDmct1z9n7EX52MlW5Rl/z PkH9s1FXK6is4DQ/QMdhcDJ0+7041n76LIOSICo1OhL92/wf15naO2zXbiDTaWz/ AhBHT8DfeQm5IIiy+1RRR15GjO0= Received: by filter0274p1iad2.sendgrid.net with SMTP id filter0274p1iad2-9398-5C6EABF0-19 2019-02-21 13:47:28.935632302 +0000 UTC m=+146163.606123613 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id oLm_YhbkRFK5ePWLeo9Jhg for <[email protected]>; Thu, 21 Feb 2019 13:47:28.931 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id DF7C93E0973 for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: priti2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+01147827abd13116724adcac68efc94a3fc745c17dace58d92cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR4J6qKpCO236iQfJoErrA7_uN-vTAvks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: DSuHr1mQ7OnnX7X0BmikDnzimrMi9DExV1V5Q/ECqPfPkpd2PU1CFhjBSeNQ9HgFZmQ57liuoSkaNG 9D+xBKYRH26FaY57eVek8Sk4BRiA4dvCCIqH8sydzLH6wuAz8dgN4Ok4gE5pz1VtMQppgVcZvowdsJ 5tu7TG4t3kvZ9jKqGYpYRJUw0Ip3SRUXkJgLWdK5/nBUUcwVQUzVYYGt3ZmDsyKOKAAWbZe1GUllVY 4=

----==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR4J-gS2nm98di4VEcN1UO9jLHKDlZLks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR4J3fymUwRD8U0gYGPzoLays7jbbjKks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21065 (comment)", "url": "#21065 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812--

[dipti2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (263/250 (105%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o11.sgmail.github.com ([167.89.101.202]:55902) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3R-HA for [email protected]; Thu, 21 Feb 2019 13:48:10 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=7p4O/gZMhR1XBVnySDch4uJlGvg=; b=qi1JmezmuiqBwfJs /bmcNNIWy0y79XXrpVaReVKHHKSE8Z1+oO5/Ovth5++u1IPMi/MqHFoCxAjYa0zl xOJcXNrnTd66Dr+fqvzw0LQAHswtNgkE7l3SjpSp/kOckSXpLR3d7aIKZtxtqH8L lvP+Mq1BAMlWi0+Fj9JjQtW5nys= Received: by filter1179p1las1.sendgrid.net with SMTP id filter1179p1las1-9821-5C6EABF0-2F 2019-02-21 13:47:28.977634557 +0000 UTC m=+1101104.146009249 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0017p1iad2.sendgrid.net (SG) with ESMTP id 8EWZ6oieQpCC26yPi53bmA for <[email protected]>; Thu, 21 Feb 2019 13:47:28.927 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id C25603E0F83 for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0c035f_4caf3fe952ed45c43679d5"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: dipti2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011477ee2a2c85569445c8c060647392c445e4400bf18e4e92cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR37r5E7ubx7VSwDA71lX5V7Hw4uQo_ks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: bMwMU6hYaQrzw/g3mau/H2rYSkYIh/tZORRBcROMXDSI69mNqwGTMuebKlmp7V/4rVD3Zl5bIEAi13 v2PPBkDyHwURpnMe+u/daHAuZfOtc7/L51fGuxpt+lGzikh6hlY3S1O7saOVHW6HQ2OCkdlmXKkX2n 5PmTeRHHObzCbM+IYRn5jfKwf/SejfdliBZVO3lGk+t/H9kw/PD2N4qGxwHJP3xaqGChsBI3efm9S/ k=

----==_mimepart_5c6eabf0c035f_4caf3fe952ed45c43679d5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0c035f_4caf3fe952ed45c43679d5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR37nTRdM8fJl-yhqrmNxtf62IcBb62ks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR37pychrnttJ3ikqaHyNDytMdmuax6ks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21065 (comment)", "url": "#21065 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6eabf0c035f_4caf3fe952ed45c43679d5--

[prakash2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (264/250 (105%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o4.sgmail.github.com ([192.254.112.99]:27538) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3K-OK for [email protected]; Thu, 21 Feb 2019 13:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=BZF8VNtu83nkD3q+3lSnkgxMVBc=; b=Fhop4++2eC3oVS5I piDAvLyur6wQn5Hm70xdCjIHVFSvkTRz1gkZwSbOYpzcikPhvTsHCzBwObixCu/o bLYFvC1G1aBOkClrcNwjiBV6bOVUF1tAZulgh7KaS8h1bivYhU6DOKuzeFaXDIII 33zvBVuVQ8AKYQ4S+3niIgQuauU= Received: by filter0417p1iad2.sendgrid.net with SMTP id filter0417p1iad2-29335-5C6EABF0-12 2019-02-21 13:47:28.54720395 +0000 UTC m=+1358258.760556136 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id eBahOhDqT9iLdAdIDSGzHQ for <[email protected]>; Thu, 21 Feb 2019 13:47:28.502 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 76E533E007B for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0754f4_4caf3fe952ed45c436742b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: prakash2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114756a529af60289a628b36b33e3d2ace9bb721554b9b792cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR1arw_ZatYEAsykR0CX0MxBeyOpOaeks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: Z5kvqomDAcbyTX3oIIH2iGoI7FuObya1psZV3iCEKraS4MLuM/QHUB5gq5LpPl4S6+TEbUy24kyb0v qdzB05t36WSiGj+E9m5kH7wR18TtK2zjT/KNkdBfk5gqRkepEZAcerPVxlw1uM4Qdisuu9GxjqEM8s YjR00CUsvKxQ5Mv+A6crKykDIIju+9BgWnQgpHWUCBBqE6DK+4W3LXEi3H7Ly58mw5BQ2fEz2m+Sym w=

----==_mimepart_5c6eabf0754f4_4caf3fe952ed45c436742b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0754f4_4caf3fe952ed45c436742b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR1apQHxyJyDLq2kS-OoiITYIweAqXJks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR1ai2la227MB4rd9r3_Z--uMUYsw_kks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21065 (comment)", "url": "#21065 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6eabf0754f4_4caf3fe952ed45c436742b--

[nainesh2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (265/250 (106%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o4.sgmail.github.com ([192.254.112.99]:64874) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3Q-Tk for [email protected]; Thu, 21 Feb 2019 13:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=A1qdDEfzKXqIJtu/eqhAQeYxHx0=; b=IKRPLdeW4VXIdDBI GFyS6CI2qPqbRduPF3P5rWaPcNutw3ktI4VWb0aYEpO88VVVWVsCcYQYxJXbgS1R MO91X+yFYK/CA6oJk5qg9Fywu3bjcLkMynpTKCR+OwCJ/rlABqWgDMzKdnCjLZnr j2UiYM6czyhkLdf0RvDjeiPTjRM= Received: by filter0210p1iad2.sendgrid.net with SMTP id filter0210p1iad2-793-5C6EABF0-26 2019-02-21 13:47:28.668119148 +0000 UTC m=+1357918.154631094 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0009p1iad2.sendgrid.net (SG) with ESMTP id 9171ZQ9qQgaqId-YYyqp6g for <[email protected]>; Thu, 21 Feb 2019 13:47:28.717 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id A5FED3E0095 for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0a41d3_4caf3fe952ed45c4367615"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: nainesh2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114778bf9f7bfb6a05c082ea2b85edc3cb1c3b95a850d6a92cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3i954YKh0dpFfzF1uy5QDi3pMlxXMks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: jLkRIf5Dzf/1ocDCUTrNO0wPikWbGikyk2/S+H1FbeUk8E7S1j/13cVsxd17tcE1qNextdP7CSYtHZ 1Yq78t3byfm7Ftm3u+DHUsoe8YtOEzbcocblcAIdMSBca6SKTCyq74czIOIXcxz50vOt7z6t49xcDZ aDUGkin5tdTt3A8O0Dj/xWdblgQlV3TZHNiZ4vCpyXr8sJatJduWeJ3gX/EnPCjpnsqUiRDaJuMdHZ I=

----==_mimepart_5c6eabf0a41d3_4caf3fe952ed45c4367615 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0a41d3_4caf3fe952ed45c4367615 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR3i4zuvxPufLitzKtBWymnHjuzVGjdks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR3i45gUTOYDFqESgynpGfu3FvmSgw7ks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#21065 (comment)", "url": "#21065 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6eabf0a41d3_4caf3fe952ed45c4367615--

[nilesh2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (307/250 (122%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 20560 characters long; only the first ------ 5000 or so are included here. Received: from out-2.smtp.github.com ([192.30.252.193]:37361) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwojm-000GRi-2b for [email protected]; Thu, 21 Feb 2019 13:50:06 +0000 Date: Thu, 21 Feb 2019 05:49:25 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756965; bh=QYEaxph+Ccs7hNfY7BiuhH0quC2nO11faJTWk3j1Er8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0otsmH1QbIhh6fO8IaUVWlizmJZpuPPTDT/ev7X9+U/VGK+X18D8+LQG6Uz3K5Mrn +4KioCEQjaiOj2pxjVi72B8s/9heX7Vg1CinIiVCWVp30hTfcbnsuNtiqs03CHtMh7 dGSIm4Rf4cRXJ5PborlNCIq3UFwNh1+6r8rhKLl4= From: Ajay Ajabale <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Nilesh Lokhande <[email protected]>, Comment <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eac6541830_5e203fa7d10d45b8284483"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ajay2jcommerce X-GitHub-Recipient: nilesh2jcommerce X-GitHub-Reason: comment List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011478021696164530b0c0120c5bb8b81fc058d7a4d9a60792cf0000000118866e6592a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR4AoMoWa2rNCI61AhjzobKOlJ2tuRgks5vPqPlgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eac6541830_5e203fa7d10d45b8284483 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (262/250 (104%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from out-14.smtp.github.com ([192.30.254.197]:55989) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3T-AB for [email protected]; Thu, 21 Feb 2019 13:48:10 +0000 Date: Thu, 21 Feb 2019 05:47:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756848; bh=WcXbZtkkfPcbJk3izbkTJt6OAzUesRnCyzbl3WUhHKE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WEG592Nq5S+inATAoKyeP3SX7Ax67OyS0DQruQw4ujl+zm8u2tiz7CNlwu0V2iguR AhQhEySri89cl7NlF8Hue2Fn9kwRK4ZJwjuf+bY54zoMwI4M6LcI/WyCYrJPnZbNfr BxwSM2Mev+wqQEvuEVJewBT7nX74APwjc/6whmiA= From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: ajay2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011477aaa4cfc1921cc9bead078c4bf86818a3c30f5d320692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3qtjhschw5MPrqu3EpcPS7aQQWHR0ks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR3qnaX6RjVhdJCDvxlhqUuSdBpT7UFks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR3qt1WT1hVai9dOhlbYXCq1PEQVZJhks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context"

[prakash2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (312/250 (124%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 23454 characters long; only the first ------ 5000 or so are included here. Received: from out-6.smtp.github.com ([192.30.252.197]:33987) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwojn-000GRq-Pm for [email protected]; Thu, 21 Feb 2019 13:50:07 +0000 Date: Thu, 21 Feb 2019 05:49:26 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756967; bh=0WcO7rW+CJRnRTEwioQAM6WYMeWprudlChlz++llVc0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VeDfBVZcn4HcntXfeqQiVD+pOprgx1AvkZQg02zbIlUcel3Un76LOBPA6KMfcP7a9 PGV24o8nC9DWB4NAQPqJ/E9tQWMVd+A/oVcwp/uRlZEG3I+blvV8Hh0eTghjBi/S09 aoiwq3sVbsbZTq6ntb1ZrWH9SU1wCzkI8bISagvs= From: Nilesh Lokhande <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eac66e9e32_39ca3fbf704d45bc48913"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: nilesh2jcommerce X-GitHub-Recipient: prakash2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114756ad497d5bd97810cb6f5156a5d48736a9fd331072d92cf0000000118866e6692a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR1ahz3p4OgFLrwU3c8KHyYRkmEqrW0ks5vPqPmgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eac66e9e32_39ca3fbf704d45bc48913 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (267/250 (106%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from o10.sgmail.github.com ([167.89.101.201]:43430) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohv-000F3S-4z for [email protected]; Thu, 21 Feb 2019 13:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=YRZyzCM2/FBmfQQk9q/S2vTS/w0=; b=UQ0qJEFLe+myvVqk UqQ2rvlmimi3bWZ2kfRc8aVaRHj3oBlVomETqWNyIPmNDZd0tWKjqUG5kTka0rdo OZGlD6uDNRty3oAFK4zeW+B7O4nC5ZDpVmVewxj1W9La9NODWTSdSu9fITSHJ4Q0 o0w0Z06nYM7ZA+UjPP9+HwtZZnM= Received: by filter0357p1iad2.sendgrid.net with SMTP id filter0357p1iad2-7997-5C6EABF0-39 2019-02-21 13:47:28.859503912 +0000 UTC m=+231838.148350452 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id jy4USO2hTqS-pIBIDgAVjA for <[email protected]>; Thu, 21 Feb 2019 13:47:28.856 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id CBB9C3E11A3 for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: nilesh2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+01147802541d1ab8b334eed29027c2d1a559f23aae55242692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR4Av0T-tgV1azH4-0sVLCyv17X38Rrks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: w4I78YjotwlhC+uMz5F/zn+z+PWWXH1Np2hyvsk6OD+qVW+dubn7tUXoRev8SKSUhV0zafemmf3eFi 7JM9z25NmqP0XyZsUl7F8BtUx1MMvQ1C0mhRtdqBOq+NUP0bNhL9zdu0V7RDsBWBqPoY+TioisIAcw jCkxhBB/rnPBk+2cedvQeiszGeNIuAwRm+flm9EZn4AKvuKzk4nio3clDh2QV/6c+senw16cIA/zVs Y=

----==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0c9995_4caf3fe952ed45c436808d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR4AiVqFymUSZjymmLYzaMhudvBHnJgks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR4ArR2QFJ61z9CSxO-pohyPm4UNuCNks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key

[prakash2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (311/250 (124%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 23420 characters long; only the first ------ 5000 or so are included here. Received: from out-2.smtp.github.com ([192.30.252.193]:54053) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwojn-000GRo-Aa for [email protected]; Thu, 21 Feb 2019 13:50:07 +0000 Date: Thu, 21 Feb 2019 05:49:26 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756966; bh=mXKenpJ26AgGhcSr6Pk3mntYiJkX1dKvSVDx29iXEvY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YgJhzh8iyFUQXjPC9MHgWceI0ULqhg7wAojYZJrpywVmBWwEmCLawd2zCng+yAgY1 m5wu83v1rNn9wkvfBChifrvBbYVCgLlEu/bMPa4CMwyvxbt2CXVDz66EzvoLwapsud gsTvkCtANeSU/RGhdJo9XO3sc88Jnb8BLfI7GMgE= From: Priti <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eac66756b8_33923fc4b94d45b45604e0"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: priti2jcommerce X-GitHub-Recipient: prakash2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114756ad497d5bd97810cb6f5156a5d48736a9fd331072d92cf0000000118866e6692a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR1ahz3p4OgFLrwU3c8KHyYRkmEqrW0ks5vPqPmgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eac66756b8_33923fc4b94d45b45604e0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (266/250 (106%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from o4.sgmail.github.com ([192.254.112.99]:53462) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohv-000F3U-5X for [email protected]; Thu, 21 Feb 2019 13:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=yrRQOj7m+tN1iA+N7MX6G8Ekabg=; b=n806nTAv7MoeFBVJ 6D8uTPdb1K4sqjEdksDA784TJYv9Mc6LMBiPUUNn4ANDmct1z9n7EX52MlW5Rl/z PkH9s1FXK6is4DQ/QMdhcDJ0+7041n76LIOSICo1OhL92/wf15naO2zXbiDTaWz/ AhBHT8DfeQm5IIiy+1RRR15GjO0= Received: by filter0274p1iad2.sendgrid.net with SMTP id filter0274p1iad2-9398-5C6EABF0-19 2019-02-21 13:47:28.935632302 +0000 UTC m=+146163.606123613 Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id oLm_YhbkRFK5ePWLeo9Jhg for <[email protected]>; Thu, 21 Feb 2019 13:47:28.931 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id DF7C93E0973 for <[email protected]>; Thu, 21 Feb 2019 05:47:28 -0800 (PST) Date: Thu, 21 Feb 2019 13:47:28 +0000 (UTC) From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: priti2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+01147827abd13116724adcac68efc94a3fc745c17dace58d92cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR4J6qKpCO236iQfJoErrA7_uN-vTAvks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: DSuHr1mQ7OnnX7X0BmikDnzimrMi9DExV1V5Q/ECqPfPkpd2PU1CFhjBSeNQ9HgFZmQ57liuoSkaNG 9D+xBKYRH26FaY57eVek8Sk4BRiA4dvCCIqH8sydzLH6wuAz8dgN4Ok4gE5pz1VtMQppgVcZvowdsJ 5tu7TG4t3kvZ9jKqGYpYRJUw0Ip3SRUXkJgLWdK5/nBUUcwVQUzVYYGt3ZmDsyKOKAAWbZe1GUllVY 4=

----==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0dd921_4caf3fe952ed45c436812 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR4J-gS2nm98di4VEcN1UO9jLHKDlZLks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR4J3fymUwRD8U0gYGPzoLays7jbbjKks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50

[priti2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (308/250 (123%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 20600 characters long; only the first ------ 5000 or so are included here. Received: from out-2.smtp.github.com ([192.30.252.193]:49695) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwojm-000GRj-6Q for [email protected]; Thu, 21 Feb 2019 13:50:06 +0000 Date: Thu, 21 Feb 2019 05:49:25 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756965; bh=mcxk47LMCHT7LTuP3ul19mBg5Sf/F2LkA0hpeqCc0Sg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xzmQBXkpiU5f7eLSNTQQay9DZZnynZmjhU4dP207G7l/kl4L6m2aw25k6787DnbG/ rdYxYgdhQzFPcZarQcoD7v5ZAam3OU04lntZC0ZcC2dcW07WBrxD6iYrKXT+arH8ke 9Tyn2/Ts9gTpIabcrUryDWahYiFDYwtUhnU4Rz6Q= From: Ajay Ajabale <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eac65568d1_5e203fa7d10d45b82845e6"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ajay2jcommerce X-GitHub-Recipient: priti2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114782748d9067655fd479cec247a03b4ec801f0ed3fc8792cf0000000118866e6592a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR4J6xAOB_N264ZgDa79zF3iAKO8qGNks5vPqPlgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eac65568d1_5e203fa7d10d45b82845e6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (262/250 (104%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from out-14.smtp.github.com ([192.30.254.197]:55989) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3T-AB for [email protected]; Thu, 21 Feb 2019 13:48:10 +0000 Date: Thu, 21 Feb 2019 05:47:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756848; bh=WcXbZtkkfPcbJk3izbkTJt6OAzUesRnCyzbl3WUhHKE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WEG592Nq5S+inATAoKyeP3SX7Ax67OyS0DQruQw4ujl+zm8u2tiz7CNlwu0V2iguR AhQhEySri89cl7NlF8Hue2Fn9kwRK4ZJwjuf+bY54zoMwI4M6LcI/WyCYrJPnZbNfr BxwSM2Mev+wqQEvuEVJewBT7nX74APwjc/6whmiA= From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: ajay2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011477aaa4cfc1921cc9bead078c4bf86818a3c30f5d320692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3qtjhschw5MPrqu3EpcPS7aQQWHR0ks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR3qnaX6RjVhdJCDvxlhqUuSdBpT7UFks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR3qt1WT1hVai9dOhlbYXCq1PEQVZJhks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context"

[nainesh2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (310/250 (124%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 20597 characters long; only the first ------ 5000 or so are included here. Received: from out-12.smtp.github.com ([192.30.254.195]:48855) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwojm-000GRk-Jz for [email protected]; Thu, 21 Feb 2019 13:50:06 +0000 Date: Thu, 21 Feb 2019 05:49:25 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756965; bh=AWluRFRJpVsp+4NmV0tStwGWOEiwuuzWOfbu5qw6l6I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vSFmQlsTFpkUfuubM/3E5Vyr1d48o2hR4QpOfLIzAHqunmkIXZiablMWjmQOLp/Sx rPD7iAVbIbE62lshjFRB8y5OZokvBAWUV59dnrYaFnveOU65tBrIogLEKx8S6XBw6D IzT8W2sh34xueY+DSftp3Gs1lNm0gGBzvaqqLhP4= From: Ajay Ajabale <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eac656a33_5e203fa7d10d45b82841b8"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ajay2jcommerce X-GitHub-Recipient: nainesh2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114778b180c5007efc3c5c0398196005be454da95b8aa0b92cf0000000118866e6592a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3i_XLFTuTK3qbn7drVnpKI5AdHDFKks5vPqPlgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eac656a33_5e203fa7d10d45b82841b8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (262/250 (104%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from out-14.smtp.github.com ([192.30.254.197]:55989) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3T-AB for [email protected]; Thu, 21 Feb 2019 13:48:10 +0000 Date: Thu, 21 Feb 2019 05:47:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756848; bh=WcXbZtkkfPcbJk3izbkTJt6OAzUesRnCyzbl3WUhHKE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WEG592Nq5S+inATAoKyeP3SX7Ax67OyS0DQruQw4ujl+zm8u2tiz7CNlwu0V2iguR AhQhEySri89cl7NlF8Hue2Fn9kwRK4ZJwjuf+bY54zoMwI4M6LcI/WyCYrJPnZbNfr BxwSM2Mev+wqQEvuEVJewBT7nX74APwjc/6whmiA= From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: ajay2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011477aaa4cfc1921cc9bead078c4bf86818a3c30f5d320692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3qtjhschw5MPrqu3EpcPS7aQQWHR0ks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR3qnaX6RjVhdJCDvxlhqUuSdBpT7UFks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR3qt1WT1hVai9dOhlbYXCq1PEQVZJhks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context":

[prakash2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (309/250 (123%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 20581 characters long; only the first ------ 5000 or so are included here. Received: from o11.sgmail.github.com ([167.89.101.202]:17460) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <[email protected]>) id 1gwojm-000GRh-Jq for [email protected]; Thu, 21 Feb 2019 13:50:06 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=JH9Rw3paSKYPYeObkUQIicZLRqQ=; b=Msvgje25QWn+G0jT xa72PmqBMcQw293FYYjvUYtF1q95pL5aJx3G2uV3NDgXQ/TraSBjvSEe19dsx3e5 grj8MXSx6Tx++vVpC1QUVudnOPpRqCGU7Xfoajk3eklri1+/BBdKLpzPUAa5ulyV i9Qzrc1YE385gwWan+ucTjxoy98= Received: by filter1129p1las1.sendgrid.net with SMTP id filter1129p1las1-14943-5C6EAC64-3D 2019-02-21 13:49:25.046092193 +0000 UTC m=+239583.097555931 Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id CTmaCwwUTX60r2x3GR4--w for <[email protected]>; Thu, 21 Feb 2019 13:49:24.939 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id D9B8880022 for <[email protected]>; Thu, 21 Feb 2019 05:49:24 -0800 (PST) Date: Thu, 21 Feb 2019 13:49:25 +0000 (UTC) From: Ajay Ajabale <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eac64d7a9c_5e203fa7d10d45b82839c7"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ajay2jcommerce X-GitHub-Recipient: prakash2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+0114756a4db0c4691c80490d2f3ffbc0adf68c791f20beab92cf0000000118866e6492a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR1anp2FxJCJT9xdAMdHWEpgJ0KrjtGks5vPqPkgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected] X-SG-EID: Z5kvqomDAcbyTX3oIIH2iGoI7FuObya1psZV3iCEKrYVX5KxK3vrpH4DrJgRJXyRZ1I4St5FJfEqan hLHi2U2kX8R8fZvZogQYHJBl6EUJiN5nE/2l0aEbYaR0BbHHyn8kU98zgegY3c5yMC+HuCBehPZ4LC h1HVitSHSkBXde0iFThmxemrNcJfhzNwHPhhkgnBYd8syuywU7SIQCb7ziaF1JziiT6iPlpMPLoZxy 0=

----==_mimepart_5c6eac64d7a9c_5e203fa7d10d45b82839c7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: [email protected] Domain 2jcommerce.in has exceeded the max emails per hour (262/250 (104%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from out-14.smtp.github.com ([192.30.254.197]:55989) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <[email protected]>) id 1gwohu-000F3T-AB for [email protected]; Thu, 21 Feb 2019 13:48:10 +0000 Date: Thu, 21 Feb 2019 05:47:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550756848; bh=WcXbZtkkfPcbJk3izbkTJt6OAzUesRnCyzbl3WUhHKE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WEG592Nq5S+inATAoKyeP3SX7Ax67OyS0DQruQw4ujl+zm8u2tiz7CNlwu0V2iguR AhQhEySri89cl7NlF8Hue2Fn9kwRK4ZJwjuf+bY54zoMwI4M6LcI/WyCYrJPnZbNfr BxwSM2Mev+wqQEvuEVJewBT7nX74APwjc/6whmiA= From: Simon Sprankel <[email protected]> Reply-To: magento/magento2 <[email protected]> To: magento/magento2 <[email protected]> Cc: Subscribed <[email protected]> Message-ID: <magento/magento2/pull/21065/[email protected]> In-Reply-To: <magento/magento2/pull/[email protected]> References: <magento/magento2/pull/[email protected]> Subject: Re: [magento/magento2] Refactored Retrieval Of Entity ID To Make AbstractDataProvider Usable (#21065) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sprankhub X-GitHub-Recipient: ajay2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:[email protected]> List-Unsubscribe: <mailto:unsub+011477aaa4cfc1921cc9bead078c4bf86818a3c30f5d320692cf0000000118866df092a169ce185311ca@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR3qtjhschw5MPrqu3EpcPS7aQQWHR0ks5vPqNwgaJpZM4au7Jj> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: [email protected]

----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-( Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #21065 (comment) ----==_mimepart_5c6eabf0aa9ab_4caf3fe952ed45c4367771 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(</p> <p>Is this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#21065 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR3qnaX6RjVhdJCDvxlhqUuSdBpT7UFks5vPqNwgaJpZM4au7Jj">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR3qt1WT1hVai9dOhlbYXCq1PEQVZJhks5vPqNwgaJpZM4au7Jj.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sprankhub in #21065: No, it was just not created via github.com, but via my local system. I am currently unable to signoff my last commit :-(\r\n\r\nIs this a blocker? I see other unverified commits in the history, so it does not seem to be an issue?"}],"action":{"name":"View Pull Request","url":"#21065 (comment)"}}}</script> <script type="application/ld+json">[ { "@context":

[swnsma]

Hi @sprankhub,
Thank you for your changes!
It looks like OK for now, is not it?

[sprankhub]

No, the commit is still not verified.

[sivaschenko]

@swnsma @sprankhub licence/cla check is green. Comment #21065 (comment) seems to be outdated

[swnsma]

@sprankhub
Travis will handle this. Lets just give it time.

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-4353 has been created to process this Pull Request

[m2-assistant]

Hi @sprankhub, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.