Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truncateString #20849

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Fix truncateString #20849

merged 1 commit into from
Jul 6, 2019

Conversation

emilie-blackbird
Copy link

@emilie-blackbird emilie-blackbird commented Jan 31, 2019 •
edited
Loading

Description (*)

Fix truncateString method : "$_remainder must be of the type string, null given"

Fixed Issues (if relevant)

#16958 : Order View Issue - This tab contains invalid data

Manual testing scenarios (*)

  1. Go to admin
  2. Open a specific order in sales
  3. Some Order have the error "This tab contains invalid data"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 31, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @emilie-blackbird. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jan 31, 2019
orlangur
orlangur requested changes Jan 31, 2019
View reviewed changes
app/code/Magento/Sales/Block/Adminhtml/Items/Column/Name.php Outdated
@@ -37,7 +37,7 @@ public function truncateString(
string $value,
int $length = 80,
string $etc = '...',
string &$remainder = '',
?string &$remainder = '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not acceptable as PHP 7.0 is supported in 2.2.

Is this fixed in 2.3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.3 it isn't in strict typing.

@sidolov
Copy link
Contributor

sidolov commented Feb 8, 2019

Hi @emilie-blackbird , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

orlangur
orlangur requested changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes into a single commit so that we have perfectly clean history 😉

@p-bystritsky p-bystritsky self-assigned this Jun 5, 2019
@emilie-blackbird @p-bystritsky
Fix truncateString
891123b 
remainder must be of the type string, null given
@magento-engcom-team
Copy link
Contributor

@emilie-blackbird thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@p-bystritsky
Copy link
Contributor

@orlangur PR updated, please review.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5211 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@emilie-blackbird thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VasylShvorak VasylShvorak self-assigned this Jun 6, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team mentioned this pull request Jul 6, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 891123b into magento:2.2-develop Jul 6, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2019

Hi @emilie-blackbird, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 6, 2019
@sivaschenko
ENGCOM-5211: Fix truncateString #20849
407d3e9
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 6, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 14, 2019
@SPbryan007
Copy link

@magento give me 2.4.5-p1 instance

@magento-deployment-service
Copy link

Hi @SPbryan007. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @SPbryan007, here is your Magento Instance: https://6af5dfcaa375abb86bbdb1ca1bca77a9.instances.magento-community.engineering
Admin access: https://6af5dfcaa375abb86bbdb1ca1bca77a9.instances.magento-community.engineering/admin_d417
Login: 235e169a
Password: ac6c133dde29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Sales Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.10
Development

Successfully merging this pull request may close these issues.
8 participants
@emilie-blackbird @magento-cicd2 @magento-engcom-team @sidolov @p-bystritsky @VasylShvorak @SPbryan007 @orlangur