-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing fields to quote_address #19265
add missing fields to quote_address #19265
Conversation
Hi @ErikPel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
9d36108
to
7f15bd8
Compare
@VladimirZaets Added the translations |
@ErikPel thanks |
Hi @VladimirZaets, thank you for the review. |
✔️ QA passed |
Hi @ErikPel, thank you for your contribution! |
Description (*)
These fields are being used at magento/module-quote/Observer/Frontend/Quote/Address/VatValidator.php. But rightn now they don't exist and this check does nothing
and later
$quoteAddress->setValidatedVatNumber($customerVatNumber); $quoteAddress->setValidatedCountryCode($customerCountryCode);
Fixed Issues (if relevant)
Manual testing scenarios (*)
$customerCountryCode != $quoteAddress->getValidatedCountryCode() || $customerVatNumber != $quoteAddress->getValidatedVatNumber()
check is useless
Contribution checklist (*)