Fix mass product update with group min cart qty #19095

pmclain · 2018-11-07T04:56:37Z

Description (*)

Resolves warning when using the product edit mass-action after configuring
global group cart min qty

Fixed Issues (if relevant)

Mass attribute update fails with E_WARNING #17592 Mass attribute update fails with E_WARNING

Manual testing scenarios (*)

Add some values to System > Configuration > Catalog > Inventory > Product Stock Options > Minimum Qty Allowed in Shopping Cart
Clean config cache
Go to the Catalog > Products
Select some products in the list
Select "Update attributes" mass-action

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2018-11-07T04:56:41Z

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur · 2018-11-07T05:59:36Z

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml

@@ -132,7 +132,7 @@
                    <div class="field">
                        <input type="text" class="input-text validate-number" id="inventory_min_sale_qty"
                               name="<?= /* @escapeNotVerified */ $block->getFieldSuffix() ?>[min_sale_qty]"
-                               value="<?= /* @escapeNotVerified */ $block->getDefaultConfigValue('min_sale_qty') * 1 ?>"
+                               value="<?= /* @escapeNotVerified */ (int) $block->getDefaultConfigValue('min_sale_qty') * 1 ?>"


I don't get this. How original implementation produces a non-numeric value?

the store config allows you to set this value at the customer group level, something that is not supported at the individual product level. something that is visible when editing the inventory config at the product level.
Product inventory using store config

Product inventory after un-checking use default

The error occurs because from multiplying json, from the store config, by 1.

So after the fix some JSON string is casted to 0?

yes, should it be 1 instead? that's the value if no global config is set.

@pmclain yes, I think so. And also please preserve old logic instead of casting:
is_numeric(...) ? getConfig() * 1 : <DEFAULT GLOBAL VALUE>

Resolves warning when using the product edit mass-action after configuring global group cart min qty Fixes magento#17592

magento-engcom-team · 2018-11-30T13:41:33Z

Hi @sivaschenko, thank you for the review.
ENGCOM-3599 has been created to process this Pull Request

orlangur

Great @pmclain! I left a couple of comments but there is really no need to change anything.

orlangur · 2018-11-30T14:09:04Z

app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Inventory.php

+        $default = $this->stockConfiguration->getDefaultConfigValue('min_sale_qty');
+        if (!is_numeric($default)) {
+            $default = $this->serializer->unserialize($default);
+            $default = isset($default[GroupInterface::CUST_GROUP_ALL]) ? $default[GroupInterface::CUST_GROUP_ALL] : 1;


Get used to ?? ;)

orlangur · 2018-11-30T14:09:21Z

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml

@@ -132,7 +132,7 @@
                    <div class="field">
                        <input type="text" class="input-text validate-number" id="inventory_min_sale_qty"
                               name="<?= /* @escapeNotVerified */ $block->getFieldSuffix() ?>[min_sale_qty]"
-                               value="<?= /* @escapeNotVerified */ $block->getDefaultConfigValue('min_sale_qty') * 1 ?>"
+                               value="<?= /* @escapeNotVerified */ $block->getDefaultMinSaleQty() * 1 ?>"


We could use @noEscape here.

magento-engcom-team · 2018-11-30T14:13:30Z

Hi @orlangur, thank you for the review.
ENGCOM-3599 has been created to process this Pull Request

valdislav · 2019-01-03T22:02:13Z

app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Inventory.php

+            $default = isset($default[GroupInterface::CUST_GROUP_ALL]) ? $default[GroupInterface::CUST_GROUP_ALL] : 1;
+        }
+
+        return (int) $default;


@orlangur @pmclain Please be aware of the option when qty uses decimals, it would be better to use float.

@valdislav thanks b3a4058

@valdislav Please let me know if any additional changes are requested.

magento-engcom-team · 2019-01-25T11:42:23Z

Hi @sivaschenko, thank you for the review.
ENGCOM-3599 has been created to process this Pull Request

ghost · 2019-01-26T20:51:43Z

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team · 2019-01-26T20:52:05Z

Hi @pmclain. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

sivaschenko · 2019-03-06T12:45:16Z

Hi @pmclain , unfortunately we had to revert changes introduced in this pull request as adding a public method getDefaultMinSaleQty to an API class where not approved by architects.

Adding public method to API classes may have negative effect for extensions that have plugins applied to original public method calls (that are replaced by new method calls).

I think that backward compatible approach in this case could be modifying the getDefaultConfigValue method

magento-engcom-team added Partner: Something Digital partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Catalog labels Nov 7, 2018

magento-engcom-team added the Release Line: 2.3 label Nov 7, 2018

orlangur self-assigned this Nov 7, 2018

orlangur requested changes Nov 7, 2018

View reviewed changes

orlangur added the Progress: needs update label Nov 7, 2018

pmclain force-pushed the issues/17592 branch from 4157e35 to a17730e Compare November 8, 2018 02:11

Fix mass product update with group min cart qty

cf383a9

Resolves warning when using the product edit mass-action after configuring global group cart min qty Fixes magento#17592

pmclain force-pushed the issues/17592 branch from a17730e to cf383a9 Compare November 15, 2018 13:03

sivaschenko self-assigned this Nov 30, 2018

sivaschenko approved these changes Nov 30, 2018

View reviewed changes

magento-engcom-team added this to the Release: 2.3.1 milestone Nov 30, 2018

magento-engcom-team removed the Progress: needs update label Nov 30, 2018

orlangur approved these changes Nov 30, 2018

View reviewed changes

Fix static tests.

e945ba0

magento-engcom-team added the Progress: accept label Dec 26, 2018

valdislav reviewed Jan 3, 2019

View reviewed changes

sivaschenko added the Progress: needs update label Jan 4, 2019

Change return type to float

b3a4058

sivaschenko approved these changes Jan 25, 2019

View reviewed changes

sivaschenko removed the Progress: needs update label Jan 25, 2019

magento-engcom-team mentioned this pull request Jan 26, 2019

Mass attribute update fails with E_WARNING #17592

Closed

magento-engcom-team merged commit b3a4058 into magento:2.3-develop Jan 26, 2019

magento-engcom-team added the Award: bug fix label Jan 26, 2019

magento-engcom-team pushed a commit that referenced this pull request Jan 26, 2019

ENGCOM-3599: Fix mass product update with group min cart qty #19095

2b1c4bf

ghost mentioned this pull request Feb 8, 2019

A non-numeric value encountered on mass product update when Minimum Qty Allowed in Shopping Cart is used #21073

Closed

Nazar65 mentioned this pull request Feb 8, 2019

[Backport] A non-numeric value encountered on mass product update when.. #21080

Merged

4 tasks

dmytro-ch mentioned this pull request Mar 11, 2019

Fixed issue - Minimum Qty Allowed in Shopping Cart functionality breaks product Update Attributes functionality #21643

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mass product update with group min cart qty #19095

Fix mass product update with group min cart qty #19095

pmclain commented Nov 7, 2018

magento-engcom-team commented Nov 7, 2018

orlangur Nov 7, 2018

pmclain Nov 7, 2018

orlangur Nov 7, 2018

pmclain Nov 7, 2018 •

edited

Loading

orlangur Nov 7, 2018

magento-engcom-team commented Nov 30, 2018

orlangur left a comment

orlangur Nov 30, 2018

orlangur Nov 30, 2018

magento-engcom-team commented Nov 30, 2018

valdislav Jan 3, 2019 •

edited

Loading

pmclain Jan 4, 2019

pmclain Jan 22, 2019

magento-engcom-team commented Jan 25, 2019

ghost commented Jan 26, 2019

magento-engcom-team commented Jan 26, 2019

sivaschenko commented Mar 6, 2019

Fix mass product update with group min cart qty #19095

Fix mass product update with group min cart qty #19095

Conversation

pmclain commented Nov 7, 2018

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-engcom-team commented Nov 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmclain Nov 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magento-engcom-team commented Nov 30, 2018

orlangur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magento-engcom-team commented Nov 30, 2018

valdislav Jan 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magento-engcom-team commented Jan 25, 2019

ghost commented Jan 26, 2019

magento-engcom-team commented Jan 26, 2019

sivaschenko commented Mar 6, 2019

pmclain Nov 7, 2018 •

edited

Loading

valdislav Jan 3, 2019 •

edited

Loading