Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inversed logic for adding stockstatus for configurable product subitems #17905

Closed
wants to merge 1 commit into from

Conversation

brosenberger
Copy link
Contributor

Description

  • the current logic is inversed as it will add the filter for stock only elements when the option is activated

Fixed Issues (if relevant)

  1. Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ubitems

* the current logic is inversed as it will add the filter for stock only elements when the option is activated
* this commit fixes magento#16069
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Benjamin Rosenberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @brosenberger. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Sep 28, 2018

Hi @brosenberger , looks like inverted logic cause a lot of tests failing, can you take a look at failed tests?
Thanks!

@sidolov
Copy link
Contributor

sidolov commented Oct 12, 2018

Hi @brosenberger , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants