Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Configurable Product Type resource model 'getChildrenIds' method … #15167

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented May 12, 2018

…return format

Has been fixed return type of Magento\ConfigurableProduct\Model\ResourceModel\Product\Type\Configurable:getChildrenIds method.

Fixed Issues (if relevant)

  1. Configurable Product Type resource model 'getChildrenIds' method incorrect return format. #14061: Configurable Product Type resource model 'getChildrenIds' method incorrect return format.

Manual testing scenarios

  1. Inject class \Magento\ConfigurableProduct\Model\ResourceModel\Product\Type
  2. Apply the array of multiple configurable ids to method getChildrenIds
  3. Expecting array to have such structure: [
    "parent id" => ["child id"]
    ]

@VitaliyBoyko VitaliyBoyko added the Partner: Atwix Pull Request is created by partner Atwix label May 12, 2018
@VitaliyBoyko VitaliyBoyko self-assigned this May 12, 2018
@VitaliyBoyko VitaliyBoyko requested a review from rogyar May 12, 2018 09:43
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 12, 2018

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur assigned orlangur and unassigned VitaliyBoyko May 12, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a backward-incompatible change for anyone who used this method before? Two-dimensional array is changed to one-dimensional.

Why 2.3-develop is targeted instead of 2.2-develop?

@VitaliyBoyko VitaliyBoyko changed the base branch from 2.3-develop to 2.2-develop May 12, 2018 11:28
@VitaliyBoyko VitaliyBoyko changed the base branch from 2.2-develop to 2.3-develop May 12, 2018 11:28
@VitaliyBoyko
Copy link
Contributor Author

Hi @orlangur!
Thank you for review.
I will make backports for other tags when this one will be accepted.

@VitaliyBoyko VitaliyBoyko self-assigned this May 12, 2018
@VitaliyBoyko VitaliyBoyko requested a review from orlangur May 14, 2018 11:06
@VitaliyBoyko VitaliyBoyko added the partners-contribution Pull Request is created by Magento Partner label May 14, 2018
@VitaliyBoyko VitaliyBoyko deleted the 14061-Configurable-Product-Type-resource-model-getChildrenIds-method-incorrect-return-format branch July 9, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants