Type cast Ids from String to Integer

[yogeshsuhagiya]

The methods getGroupId and getTaxClassId should set and return the Integer value of Id but they are returning String values.
And the method getSharedWebsiteIds should return integer type array of website Ids but it's returning the string type array of website Ids.
So before setting the value of Ids, I've typecast the value of Id from String to Integer.

Description

Fixed Issues (if relevant)

1. Getting group id from customer session returns wrong data type. #14055: Getting group id from customer session returns wrong data type.

Manual testing scenarios

N/A

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[ihor-sviziev]

Why haven't you changed added casting from string to int here?

[yogeshsuhagiya]

I'm not getting you, will you please elaborate?

[bydrei]

@yogeshks he is talking about the return. The return should be type casted.

[yogeshsuhagiya]

Hi @ferrazzuk
Thanks for the correction, I'll update my commit accordingly.

[bydrei]

@yogeshks can you move the type casting to the return instead?

[lbajsarowicz]

I don't like the idea of change ID type to int - I still believe that other DBMS drivers (abstraction) are going to be developed for Magento sooner or later, then UUID can be required instead of Auto-Increment int value.

IMHO: We should keep getId() method for both Interface (you forgot) and Implementation class return type string.

PS: You have to keep in mind that change to interface can affect thousands of Magento 2 instances after update.

[bydrei]

@lbajsarowicz I disagree with you for these two reasons:

1. If you have a look at the database (even thought the changes are not being made to the database) the type of group_id is of INT type. Same goes to the group tax id class and website id.
2. Keeping it as a string doesn't keep the consistency of data types and also doesn't match the function comments and even the comments in the interface.

Its makes sense to keep data type's consistency in this case.

[yogeshsuhagiya]

Hi @ferrazzuk,
Are my changes eligible for the merge with magento/magento2 branch? Will you please let me know.

[ihor-sviziev]

Hi,
I don't mind to add those changes. Cc @orlangur
Any thoughts?

[bydrei]

@yogeshks I don't take those decision. I'm just a contributor like you

[orlangur]

Closing PR as mentioned issue is not valid.

This issue is not valid, see #10519 (comment) for more details.

Thanks for collaboration @ferrazzuk and @yogeshks!