Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.3] #12936 out-of-stock options for configurable product visible as sellable #13417

Merged
merged 1 commit into from
Feb 7, 2018
Merged

[Backport 2.3] #12936 out-of-stock options for configurable product visible as sellable #13417

merged 1 commit into from
Feb 7, 2018

Conversation

coderimus
Copy link
Contributor

@coderimus coderimus commented Jan 29, 2018

Description

This is the backport of the #12936 where next issue was fixed: when a configurable product has 2 options and one of the values of this option is out-of-stock but enabled it will be visible as in stock and can be selected. It will not be added to cart but cause incorrect behaviour.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

As explained in #12936

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@coderimus
Copy link
Contributor Author

Hello @adrian-martinez-interactiv4 can you please check this backport? I would be grateful if you also will find a time and help me with the test result failed error. Please, check Travis report. Is it something related to my changes? Many thanks to you :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reviewed

@adrian-martinez-interactiv4
Copy link
Contributor

@coderimus failing test solved, changes reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants