Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command "app:config:status" to check if "app:config:import" needed #12441

Merged
merged 3 commits into from
Dec 1, 2017

Conversation

jalogut
Copy link
Contributor

@jalogut jalogut commented Nov 25, 2017

Description

Add command app:config:status to check whether config propagation is up to date. This command can be used to decide whether app:config:import execution is needed during deployments.

Fixed Issues

On version 2.2 a new command setup:db:status was added to decide whether executing setup:upgrade is required. The purpose of this command was to add the possibility of deploying without executing setup:upgrade if module versions are up to date.

With the same objective, a command to check the config status is needed to decide whether app:config:import is needed.

Issue
If setup:upgrade is not executed, we need to always execute app:config:import because there is no way to know, if config files are up to date or not. This will mean, we still need to set the maintenance and we cannot simply switch the code to the new version.

Solution
Using app:config:status, we would be able to switch to a new version without the need of a maintenance, if setup:db:status also returns that everything is up to date

Manual testing scenarios

Thanks to this command, we would be able to deploy without maintenance as follows:

1.- Check setup:db:status returns All modules up to date
2.- Check app:config:status returns Configuration files are up to date.
3.- No maintenance is required because we do not need to execute setup:upgrade or app:config:import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…on is up to date. This command can be used to decide whether app:config:import execution is needed
@jalogut
Copy link
Contributor Author

jalogut commented Nov 25, 2017

@fooman fooman self-assigned this Nov 25, 2017
@fooman fooman added this to the November 2017 milestone Nov 25, 2017
@okorshenko okorshenko merged commit 13574b4 into magento:2.2-develop Dec 1, 2017
okorshenko pushed a commit that referenced this pull request Dec 1, 2017
@hostep
Copy link
Contributor

hostep commented May 2, 2018

Quick heads-up: This was supposed to be added to Magento 2.2.4, and it is, but unfortunately the line which was added to the di.xml file has been (accidentally?) removed by this commit: e6b6c65#r28828688

Can someone try to figure out how this happened and if something needs to happen around this? In Magento 2.2.4 the line is gone, in the 2.2-develop branch it still exists (at the moment of writing) ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants