Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport for 2.1 of #9904] #8069: Saving Category with existing imag… #12368

Merged
merged 1 commit into from
Dec 13, 2017
Merged

[Backport for 2.1 of #9904] #8069: Saving Category with existing imag… #12368

merged 1 commit into from
Dec 13, 2017

Conversation

nemesis-back
Copy link

@nemesis-back nemesis-back commented Nov 20, 2017 •
edited
Loading

Description

Exception triggered every time a category that has an image is saved.
This PR is backport of #9904

Fixed Issues

  1. Saving Category with existing image causes an exception #8069: Saving Category with existing image causes an exception

Manual testing scenarios

  1. Create a new category an add an image
  2. Edit category and save, without change any attributes
  3. Observer logs

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added bugfix Component: Catalog Fixed in 2.3.x The issue has been fixed in 2.3 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 20, 2017
@osrecio osrecio self-assigned this Nov 21, 2017
@osrecio osrecio added this to the November 2017 milestone Nov 23, 2017
@osrecio
Copy link
Member

osrecio commented Nov 23, 2017

Thanks for your contribution @nemesis-back , I'm working on it.

@osrecio
Copy link
Member

osrecio commented Dec 3, 2017

Still working on it, I'm running some tests about it. This week will be resolved. Thanks for your patience @nemesis-back

@magento-team magento-team merged commit 5d1ec8b into magento:2.1-develop Dec 13, 2017
magento-team pushed a commit that referenced this pull request Dec 13, 2017
MAGETWO-84432: [Backport for 2.1 of #9904] #8069: Saving Category wit…
14293ce 
…h existing imag… #12368
@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@osrecio osrecio

Labels
bugfix Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@nemesis-back @osrecio @magento-team @okorshenko @magento-engcom-team