Fix js error when disable/enable wysiwyg editor #12141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues when disable/enable WYSIWYG editor with
ui/form/element/helper/service
checkbox:Uncaught TypeError: Cannot read property 'controlManager' of null at UiClass.setDisabled (wysiwyg.js:98)
Manual testing scenarios
Open
app/code/Magento/Catalog/view/adminhtml/ui_component/category_form.xml
Replace description field with the following code:
Navigate to category edit form and try to use "Use Default Value" checkbox below description field.
Js error will be logged to the console and the last button will be disabled only.
Apply the patch to fix js error and all buttons will be disabled.
Contribution checklist