Changed Validation to get store for block #11601
Conversation
|
So as far I a see this fixes the issue raised but there is another issue with the block validation. In my testing I setup a multi store system so there are two store views for a website. I then added 2 blocks with the id example for store 1 and store 2. I then went to add a 3rd block to store 2 with the id example and the system lets me do this. My thinking is that the validation should check to make sure you are not adding the same block twice to the same store.
|
| @@ -183,7 +183,7 @@ public function getIsUniqueBlockToStores(AbstractModel $object) | |||
| $entityMetadata = $this->metadataPool->getMetadata(BlockInterface::class); | |||
| $linkField = $entityMetadata->getLinkField(); | |||
|
|
|||
| if ($this->_storeManager->hasSingleStore()) { | |||
| if ($this->_storeManager->isSingleStoreMode()) { | |||
| $stores = [Store::DEFAULT_STORE_ID]; | |||
| } else { | |||
| $stores = (array)$object->getData('stores'); | |||
There was a problem hiding this comment.
The store validation seems to be broken here as the data set on the object is under store_id and not stores.
There was a problem hiding this comment.
Or maybe better still would be to use the getStores method that is against the Block model.
|
Yes is my teamate @thiagolima-bm , What que do? |
|
@osrecio nothing to do now with this pr. We will process both of them to improve/fix the cms block admin experience. Thank you for your code. |
|
Solved this PR in /pull/11802 |
Changed validation to
getIsUniqueBlockToStoresDescription
Changed validation to get
DEFAULT_STORE_IDwhen the app is setted withSingleStoreModein the other cases get store from objectFixed Issues (if relevant)
Manual testing scenarios
noContribution checklist