Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.1-develop] #11328 : app:config:dump adds extra space every time in multiline array value #11451

Merged
merged 5 commits into from
Oct 24, 2017
Merged

[Backport 2.1-develop] #11328 : app:config:dump adds extra space every time in multiline array value #11451

merged 5 commits into from
Oct 24, 2017

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 commented Oct 14, 2017 •
edited by davidalger
Loading

Related PRs:

app:config:dump adds extra space every time in multiline array value

Description

Rewrite PhpFormatter::format method, to avoid add extra spaces

Fixed Issues (if relevant)

  1. app:config:dump adds extra space every time in multiline array value #11328: app:config:dump adds extra space every time in multiline array value

Manual testing scenarios

Described in issue #11328

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This was referenced Oct 18, 2017
Merged
Merged
@davidalger davidalger self-assigned this Oct 18, 2017
@davidalger davidalger added this to the October 2017 milestone Oct 18, 2017
@davidalger davidalger added Release Line: 2.1 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 18, 2017
@okorshenko okorshenko merged commit 1a28e45 into magento:2.1-develop Oct 24, 2017
okorshenko pushed a commit that referenced this pull request Oct 24, 2017
MAGETWO-82237: [Backport 2.1-develop] #11328 : app:config:dump adds e…
c567804 
…xtra space every time in multiline array value #11451
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 deleted the FR21#11328-APP-CONFIG-DUMP-EXTRA-SPACES branch October 24, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidalger davidalger davidalger approved these changes

Assignees

@davidalger davidalger

Labels
Award: test coverage Progress: accept Release Line: 2.1 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@adrian-martinez-interactiv4 @davidalger @magento-team @vkublytskyi @okorshenko