Fix the correct removal of the images and the removal of all images in the catalog #11147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2017
okorshenko
pushed a commit
that referenced
this pull request
Oct 4, 2017
…of all images in the catalog #11147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the correct removal of the images and the removal of all images in the catalog
Description
When you want remove image from admin panel, this file is not removed correctly.
If the path of the image saved in the table catalog_product_entity_media_gallery is empty, this remove all the catalog.
Manual testing scenarios
For the first case.
The file is not removed in pub/media/catalog/product/....
For the second case.
All the files are removed in pub/media/catalog/product/....
Contribution checklist