Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colinmollenhour/credis library #11126

Conversation

orlangur
Copy link
Contributor

@orlangur orlangur commented Sep 28, 2017

Description

Fixed Issues

  1. There is at least one bug in this library affecting Magento installations: Redis Cache error #9875, Upgrade from Magento CE 2.1.9 to 2.2.0 - Element 'block', attribute 'class': [facet 'pattern'] The value '\Magento\Framework\View\Element\Template' is not accepted by the pattern '[A-Z][a-zA-Z\d]*(\\[A-Z][a-zA-Z\d]*)*'. #11110 (comment)
  2. There are new features in-demand by Magento developers: Consider credis library update to allow Redis Sentinel cluster usage #10962
  3. Probably Redis cache need Fix #10524 will be fixed as well

Manual testing scenarios

  1. Configure Redis as session storage
  2. Configure Redis as cache storage
  3. Run some Selenium-based functional/acceptance tests to check that at least main Magento scenarios are not broken

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur added this to the September 2017 milestone Sep 28, 2017
@vrann vrann self-assigned this Sep 29, 2017
@vrann vrann reopened this Sep 29, 2017
@maderlock
Copy link

There are serious problems since 2.1.8 in the 2.1.x branch, so assuming this fixes #10524, please please port this to 2.1 once you've finished with 2.2.

Please.

Those of us using 2.1 are screwed otherwise as we currently cannot use Redis at all. Thanks.

@maderlock
Copy link

OMG - is that the extent of the fix? OK, I'll test this on 2.1.9.

@orlangur
Copy link
Contributor Author

orlangur commented Oct 5, 2017

Closing in favor of #11222.

@orlangur orlangur closed this Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants