Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6712 Remove additional margin for footer links widget; prevents layou… #11063

Merged

Conversation

fragdochkarl
Copy link

@fragdochkarl fragdochkarl commented Sep 26, 2017

Description

Add a CSS selector to remove an additional top-margin, rendered when adding a link widget to the footer in luma theme.

Fixed Issues (if relevant)

  1. Footer Links Widget CSS Issue #6712: Footer Links Widget CSS Issue

Manual testing scenarios

  1. Follow instructions of Issue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

heyitsroberthe and others added 3 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 26, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ paliarush
❌ viktym
❌ sandrowagner

@okorshenko
Copy link
Contributor

Hi @fragdochkarl could you please sign CLA?

@fragdochkarl
Copy link
Author

I did sign the CLA. When I click on it again it says "Thank you for signing the CLA" and redirects back to github... 😸

@vrann
Copy link
Contributor

vrann commented Sep 27, 2017

@fragdochkarl thanks, seems like our tools are crazy because the branch base history diverges. Should be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants