Created memory efficient iterator for importexport_importdata table #10918
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| namespace Magento\ImportExport\Model\ResourceModel\Import\Data; | ||
|
|
||
| /** | ||
| * DataProvider for import data | ||
| */ | ||
| class DataProvider extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb | ||
|
There was a problem hiding this comment. Please name classes properly, not a word-per-folder. |
||
| { | ||
| /** | ||
| * Ids of rows in table | ||
| * @var array | ||
| */ | ||
| protected $rowsIds = []; | ||
|
|
||
| /** | ||
| * DataProvider constructor. | ||
| * @param \Magento\Framework\Model\ResourceModel\Db\Context $context | ||
| * @param string $connectionName | ||
| */ | ||
| public function __construct( | ||
| \Magento\Framework\Model\ResourceModel\Db\Context $context, | ||
| $connectionName = null | ||
| ) { | ||
| parent::__construct($context, $connectionName); | ||
| } | ||
|
|
||
| /** | ||
| * Resource initialization | ||
| */ | ||
| protected function _construct() | ||
| { | ||
| $this->_init('importexport_importdata', 'id'); | ||
| } | ||
|
|
||
| /** | ||
| * Get all existing rows ids to use them later for efficient data retrieval | ||
| * @return array | ||
| */ | ||
| protected function getRowsIds() | ||
| { | ||
| if(empty($this->rowsIds)) { | ||
| $connection = $this->getConnection(); | ||
|
|
||
| $select = $connection | ||
| ->select() | ||
| ->from($this->getMainTable(), ['id']) | ||
| ->order('id ASC'); | ||
|
|
||
| $this->rowsIds = $connection->fetchCol($select); | ||
| } | ||
|
|
||
| return $this->rowsIds; | ||
| } | ||
|
|
||
| /** | ||
| * Returns import data row by $index | ||
| * | ||
| * @param $index int | ||
| * @return array | ||
| */ | ||
| public function getImportDataRow($index) | ||
| { | ||
| $rowsIds = $this->getRowsIds(); | ||
|
|
||
| if(!isset($rowsIds[$index])) { | ||
| return null; | ||
| } | ||
|
|
||
| $connection = $this->getConnection(); | ||
|
|
||
| $select = $connection | ||
| ->select() | ||
| ->from($this->getMainTable(), ['data']) | ||
| ->order('id ASC') | ||
| ->where('id = ?', $rowsIds[$index]); | ||
|
|
||
| $statement = $connection->query($select); | ||
|
|
||
| $row = $statement->fetch(); | ||
|
|
||
| return [$row['data']]; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| namespace Magento\ImportExport\Model\ResourceModel\Import\Data; | ||
|
|
||
| /** | ||
| * Import data iterator | ||
| */ | ||
| class Iterator implements \Iterator | ||
|
There was a problem hiding this comment. Please name classes properly, not a word-per-folder. |
||
| { | ||
| /** | ||
| * Current iterator index | ||
| * @var int | ||
| */ | ||
| protected $currentIndex = 0; | ||
|
|
||
| /** | ||
| * @var DataProvider | ||
| */ | ||
| protected $importDataProvider = null; | ||
|
|
||
| /** | ||
| * @var DataProviderFactory | ||
| */ | ||
| protected $importDataProviderFactory; | ||
|
|
||
| /** | ||
| * Iterator constructor. | ||
| * @param DataProvider $importDataProvider | ||
| */ | ||
| public function __construct(DataProviderFactory $importDataProviderFactory) { | ||
| $this->importDataProviderFactory = $importDataProviderFactory; | ||
| } | ||
|
|
||
| /** | ||
| * Returns current row | ||
| * | ||
| * @return array | ||
| */ | ||
| public function current() | ||
| { | ||
| if($this->importDataProvider == null) { | ||
| $this->importDataProvider = $this->importDataProviderFactory->create(); | ||
| } | ||
|
|
||
| return $this->importDataProvider->getImportDataRow($this->currentIndex); | ||
| } | ||
|
|
||
| /** | ||
| * Moves iterator to next row | ||
| */ | ||
| public function next() | ||
| { | ||
| $this->currentIndex++; | ||
| } | ||
|
|
||
| /** | ||
| * Gets current row key | ||
| * @return int | ||
| */ | ||
| public function key() | ||
| { | ||
| return $this->currentIndex; | ||
| } | ||
|
|
||
| /** | ||
| * Returns if current row is valid | ||
| * @return int | ||
| */ | ||
| public function valid() | ||
| { | ||
| return $this->current() !== null; | ||
| } | ||
|
|
||
| /** | ||
| * Rewinds iterator to first row | ||
| */ | ||
| public function rewind() | ||
| { | ||
| $this->currentIndex = 0; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See http://devdocs.magento.com/guides/v2.0/contributor-guide/backward-compatible-development/#adding-a-constructor-parameter for a correct way to add new dependency.