Code generate: support variadic parameter #10771
Conversation
|
|
|
Hi @kenboy |
|
Hi @ishakhsuvarov |
|
@kenboy Thank you |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function variadic(... $values) |
There was a problem hiding this comment.
It would be nice to extend this case to support multiple arguments before variadic, and type-hinted variadic (something in the lines of zend-code test asset).
There was a problem hiding this comment.
Also, do you think that space should be used after ...? As far as I can see it is usually omitted.
There was a problem hiding this comment.
Uniformity with zend-code ParameterGenerator
|
Hi @ishakhsuvarov |
[EngCom] Public Pull Requests - MAGETWO-72390: Remove the usage of the DataObject for response management #10808 - MAGETWO-71545: Added 'application/json' Content-Type to Ajax responses in the Magento_UI module. #10521 - MAGETWO-72388: Fix spelling mistake in AddressTest.php #10806 - MAGETWO-72283: Code generate: support variadic parameter #10771
Support variadic parameter
Description
Fix error:
Fatal error: Declaration of TNW\Salesforce\Synchronize\Unit\Customer\Account\Lookup\ByName\Interceptor::get($path, $objects) must be compatible with TNW\Salesforce\Synchronize\Unit\UnitInterface::get($path, ...$objects)
Contribution checklist