Fix for url_rewrite on page delete via api #10568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: when deleting a cms page via api the url_rewrites aren't deleted Steps to reproduce: - add cms page via api - delete cms page via api - add new cms page with same identifier via api - ERROR: Could not save the page, URL key already exists Solution: moved di.xml from etc/adminhtml to etc/ folder in CmsUrlRewrite module Event trigger to delete url rewrites is located in di.xml
|
|
avdb
pushed a commit
to avdb/magento2
that referenced
this pull request
Aug 17, 2017
For develop see PR magento#10568 Problem: when deleting a cms page via api the url_rewrites aren't deleted Steps to reproduce: - add cms page via api - delete cms page via api - add new cms page with same identifier via api - ERROR: Could not save the page, URL key already exists Solution: moved di.xml from etc/adminhtml to etc/ folder in CmsUrlRewrite module Event trigger to delete url rewrites is located in di.xml
4 tasks
|
@avdb Would be really nice to cover this change with an api-functional test. Do you need any help with that? |
- api-functional test added
|
@avdb Added test on our side. |
magento-team
pushed a commit
that referenced
this pull request
Aug 18, 2017
magento-team
pushed a commit
that referenced
this pull request
Aug 18, 2017
[EngCom] Public Pull Requests - MAGETWO-71659: Fix for url_rewrite on page delete via api #10568 - MAGETWO-71617: Fixes Regression in 2.2 - menu.xml config ignored #10543 - MAGETWO-71380: Fix JS translation search #10445 - MAGETWO-71201: Improved calculating version hash for the js-translation.json file. #10378
|
@magento-team Will this be backported to 2.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when deleting a cms page via api the url_rewrites aren't deleted
Steps to reproduce:
Solution: moved di.xml from etc/adminhtml to etc/ folder in CmsUrlRewrite module
Event trigger to delete url rewrites is located in di.xml
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist