Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order date format in Orders Grid #10260

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jul 17, 2017

Description

We still have incorrect order date format in 2.1. Need to fix it. This fix removes custom date form that was defined for order grid and use default implementation:
https://github.com/magento/magento2/blob/develop/app/code/Magento/Ui/view/base/web/js/grid/columns/date.js#L18

Fixed Issues (if relevant)

  1. Fix order date format in admin grid #6785: Fix order date format in admin grid
  2. fixing time format on admin sales order grid #8336: fixing time format on admin sales order grid
  3. Purchase date on admin screen is always *:07:00 #5651: Purchase date on admin screen is always *:07:00

Manual testing scenarios

  1. Create customer, create product, create order
  2. Go to admin, navigate to Sales->Orders grid
  3. See the date, i.e. "Jan 30, 2017, 16:01:00 PM" (should be Jan 30, 2017, 4:01:00 PM)
  4. Open the order and check the date under "Order Date"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Jul 17, 2017
@okorshenko okorshenko added this to the July 2017 milestone Jul 17, 2017
@magento-team magento-team merged commit 9774b93 into magento:2.1-develop Jul 18, 2017
magento-team pushed a commit that referenced this pull request Jul 18, 2017
[EngCom] Public Pull Requests - 2.1

 - MAGETWO-70771: Fix order date format in Orders Grid #10260
@ihor-sviziev ihor-sviziev deleted the patch-6 branch October 5, 2017 07:23
@hostep
Copy link
Contributor

hostep commented Apr 17, 2018

@ihor-sviziev: could it be that this PR has been reverted (maybe accidentally) in: bbaebf7#diff-f13026afcc46259a8ef9e8bc19ccf79eL189 ?

And if not done accidentally, was it done with a certain purpose, could you try to find out?

The format did change in between Magento 2.1.7 and 2.1.8 from MMM dd, YYYY, H:MM:SS A to MMM dd, YYYY, H:mm:ss A which fixes the incorrect minutes and seconds, but does not fix the AM/PM problem you described.

@ihor-sviziev
Copy link
Contributor Author

@hostep looks like it was done by mistake. Feel free to create new PR with the same changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants