Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attribute vat_id frontend_label to make it translatable #10140

Merged
merged 4 commits into from
Jul 5, 2017
Merged

Update attribute vat_id frontend_label to make it translatable #10140

merged 4 commits into from
Jul 5, 2017

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Jul 4, 2017

Description

VAT Number field in checkout isn't translated because label is VAT number. This PR will update the frontend_label of vat_id to make it translatable again.

Fixed Issues (if relevant)

  1. None that I could find.

Manual testing scenarios

  1. Install for example https://github.com/ho-nl/magento2-nl_NL (Source of strings is Crowdin).
  2. On checkout page VAT Number isn't translated.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Jeroen added 2 commits July 4, 2017 14:42
Value is `VAT number` while translation string is `VAT Number`.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 4, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Jul 4, 2017
@ishakhsuvarov ishakhsuvarov added this to the July 2017 milestone Jul 4, 2017
@magento-team magento-team merged commit 796ba71 into magento:develop Jul 5, 2017
@JeroenVanLeusden JeroenVanLeusden deleted the JeroenVanLeusden-patch-1 branch July 6, 2017 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants