Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referrerPolicy to Vimeo Video iframe to allow domain-restricted videos #10105

Merged

Conversation

davefarthing
Copy link
Contributor

@davefarthing davefarthing commented Jun 30, 2017

Description

When Vimeo videos are domain restricted, (see Vimeo ) they require that the video iFrame passes a referrer header. This is missing from the existing implementation and domain restricted videos will not play.

Setting the referrerPolicy (MDN) the iFrame correctly sends the referrer header with the video request.

Fixed Issues (if relevant)

n/a

Manual testing scenarios

  1. Embedd a domain restricted Vimeo video against a product.
  2. Check the video displays correctly on the frontend

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 30, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 30, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 30, 2017
@okorshenko okorshenko modified the milestones: June 2017, July 2017 Jul 2, 2017
@magento-team magento-team merged commit d72d1a8 into magento:develop Jul 5, 2017
magento-team pushed a commit that referenced this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants