Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default welcome message returns after being deleted #9742

Closed
robgt opened this issue May 23, 2017 · 4 comments
Closed

Default welcome message returns after being deleted #9742

robgt opened this issue May 23, 2017 · 4 comments
Assignees
@RomaKis
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@robgt
Copy link

robgt commented May 23, 2017

Default welcome message returns after being deleted

Preconditions

  1. Magento 2.1.6
  2. PHP 7

Steps to reproduce

  1. Go to Content > Configuration > Click Edit on theme being used
  2. Expand Header section to reveal "Welcome Text" field
  3. Field will be populated with "Default welcome msg!"
  4. Delete the text, and click save (or save and continue edit)
  5. Repeat steps 1 to 3.
  6. Examine same form field - contents will reappear (seemingly not deleted, although front end at this stage will not display it).
  7. Click save again
    8 Welcome text has been saved to default value again and will reappear on the website.

Expected result

  1. Default value, once deleted, should not reappear.

Actual result

  1. Default value reappears, and is applied next time you click save.
  2. Same thing happens with the Footer default copyright notice.
@Stas94
Copy link

Stas94 commented Jun 23, 2017 •
edited
Loading

@robgt Thanks for reporting this issue. We've created internal ticket MAGETWO-70166 to address this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 23, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 2, 2017
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 2, 2017 •
edited
Loading

@robgt, thank you for your report.
We've created internal ticket(s) MAGETWO-70166 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@RomaKis RomaKis self-assigned this Nov 16, 2017
@RomaKis RomaKis mentioned this issue Nov 17, 2017
Merged
4 tasks
okorshenko pushed a commit that referenced this issue Nov 28, 2017
MAGETWO-84413: 9742: Default welcome message returns after being dele…
a1cc499 
…ted #9742 #12328

 - Merge Pull Request #12328 from RomaKis/magento2:9742
 - Merged commits:
   1. 147f638
okorshenko pushed a commit that referenced this issue Nov 28, 2017
MAGETWO-84413: 9742: Default welcome message returns after being dele…
6618483 
…ted #9742 #12328
@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch. Will be available with upcoming patch release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 28, 2017
@magento-engcom-team
Copy link
Contributor

Hi @robgt. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1296 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomaKis RomaKis

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@veloraven @okorshenko @robgt @Stas94 @RomaKis @magento-engcom-team