Status label is wrong in admin

[darkogoles1]

Preconditions

1. Magento version 2.1.3, 2.1.6

Steps to reproduce

1. Create Order status labels for default frontend store: http://collabshot.com/show/MVB4Tl
2. Original status labels (for admin store should be in this table: http://collabshot.com/show/21mPgT

Expected result

When an order is created in the frontend, order status should have e.g. "erp_uploaded" code.
Label in frontend should be Processing, as we added store specific label "Processing" to "sales_order_status_label" table

But label in admin store should be the original label from "sales_order_status" table, which is not the case.

Actual result

In the file: /vendor/magento/module-sales/Model/Order/Status.php:145, the method "getStoreLabel" is trying to fetch a label for current admin store, but always returns the label for "Default" frontend store (which is id=1 in my case).

The reason is because Magento is not loading ADMIN store id but always returns default store id, even inside adminhtml area:
http://collabshot.com/show/Q8KvAK

"$this->_storeManager->getStore($store);" always returns store id=1 instead of store id=0

This makes status labels usage useless either in the frontend, either in admin, this is how above sample statuses look like in admin:

• On sales grid it looks ok: http://collabshot.com/show/jruSTa
• but inside order details screen it looks like this as having frontend label instead of admin store label: http://collabshot.com/show/APuCyI

So, finally, even the source model that is trying to fetch status label is showing Frontend label instead of original admin status label - all because of wrong store id (Default instead of admin) loaded in backend.

Best way to reproduce:

1. Create order
2. Open edit order page in admin and note "Order Status"
3. Go to Admin: Stores>Settings>Order Status and edit row with status that has order
4. Change label for Default Store View = "Processing on store view"
5. Refresh order edit form

Expected result

Status = "Processing"

Actual result

Status = "Processing on store view"

[magento-engcom-team]

We updated description:

Best way to reproduce:

1. Create order
2. Open edit order page in admin and note "Order Status"
3. Go to Admin: Stores>Settings>Order Status and edit row with status that has order
4. Change label for Default Store View = "Processing on store view"
5. Refresh order edit form

Expected result

Status = "Processing"

Actual result

Status = "Processing on store view"

[magento-engcom-team]

@darkogoles1, thank you for your report.
We've created internal ticket(s) MAGETWO-80333 to track progress on the issue.

[okorshenko]

The issue has been fixed and delivered to 2.2-develop branch. Will be available with 2.2.2 release

[magento-team]

Internal ticket to track issue progress: MAGETWO-81786

[magento-engcom-team]

Hi @darkogoles1. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1285 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

• ad6c0af
• 6d3d70a
• 6b0c02c
• c8abb13
• c6a9b5f
• c867b81
• 88a3ad0
• d87e316
• c76b04c
• 5ae2109
• 931133a
• 4c927a0
• 060a8f9
• 4da2a7d
• 008ef55
• d3642e8
• d37ce08
• b22b232
• 6c02a2d
• f2ec2ea

The fix will be available with the upcoming patch release.