Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS blocks are not validated against having same store and identifier #8236

Closed
magemash opened this issue Jan 23, 2017 · 7 comments
Closed

CMS blocks are not validated against having same store and identifier #8236

magemash opened this issue Jan 23, 2017 · 7 comments
Assignees
@thiagolima-bm
Labels
bug report Component: Cms Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@magemash
Copy link

Preconditions

  1. version - 2.12
  2. PHP7
  3. mysql Ver 15.1 Distrib 10.0.28-MariaDB

Steps to reproduce

  1. save a cms block with a selected identifier and store view
  2. save another block with the same identifier and store view

Expected result

  1. Validation error should appear

Actual result

  1. Block is saved successfully
@veloraven
Copy link
Contributor

Internal ticket was created - MAGETWO-69931

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 16, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Cms Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 4, 2017
@magento-engcom-team
Copy link
Contributor

@magemash, thank you for your report.
We've created internal ticket(s) MAGETWO-69931 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@nemesis-back
Copy link

I will work on it #SQUASHTOBERFEST 2017

@thiagolima-bm
Copy link
Member

I am working on it

thiagolima-bm added a commit to thiagolima-bm/magento2 that referenced this issue Oct 27, 2017
@thiagolima-bm
magento#8236 FIX CMS blocks
47a0843
@thiagolima-bm thiagolima-bm mentioned this issue Oct 27, 2017
Closed
@thiagolima-bm
Copy link
Member

@veloraven @okorshenko New PR

@thiagolima-bm thiagolima-bm mentioned this issue Oct 27, 2017
Merged
@thiagolima-bm
Copy link
Member

I had to create another PR to fix my forked branches.

thiagolima-bm added a commit to thiagolima-bm/magento2 that referenced this issue Oct 27, 2017
@thiagolima-bm
magento#8236 FIX CMS blocks
b0add65
thiagolima-bm added a commit to thiagolima-bm/magento2 that referenced this issue Oct 27, 2017
@thiagolima-bm
magento#8236 FIX CMS blocks
49074ff
This was referenced Oct 27, 2017
Merged
Merged
okorshenko pushed a commit that referenced this issue Oct 31, 2017
@dmanners
MAGETWO-82889: #8236 FIX CMS blocks #11802
f1f1683 
 - Merge Pull Request #11802 from thiagolima-bm/magento2:ISSUE#8236
 - Merged commits:
   1. 47a0843
   2. d3aa3f8
okorshenko pushed a commit that referenced this issue Oct 31, 2017
MAGETWO-82889: #8236 FIX CMS blocks #11802
ea55c1a
okorshenko pushed a commit that referenced this issue Oct 31, 2017
Merge pull request #1643 from magento-engcom/2.2-develop-prs
884d717 
Public Pull Requests

#11843 Save the price 0 as price in custom options [backport 2.2] by @raumatbel
#11854 FilterBuilder Doc Block Update by @ByteCreation
#11802 #8236 FIX CMS blocks by @thiagolima-bm
#11651 [BUGFIX] Solved error while upgrading from 2.1 to 2.2 by @lewisvoncken

Fixed Public Issues

#4808 The price of product custom option can't be set to 0.
#11095 Magento_Tax "postcode is a required field" when upgrading from 2.1.9 to 2.2
@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release

magento-team pushed a commit that referenced this issue Nov 2, 2017
@dmanners
MAGETWO-83101: [Backport 2.3-develop] #8236 FIX CMS blocks #11805
c0ad13c 
 - Merge Pull Request #11805 from thiagolima-bm/magento2:ISSUE#8236-2.3-develop
 - Merged commits:
   1. b0add65
   2. fca3b5e
magento-team pushed a commit that referenced this issue Nov 2, 2017
@ishakhsuvarov
MAGETWO-83101: [Backport 2.3-develop] #8236 FIX CMS blocks #11805
da2fd77
magento-team pushed a commit that referenced this issue Nov 2, 2017
@ishakhsuvarov
Merge pull request #1654 from magento-engcom/develop-prs
84e7c86 
[EngCom] Public Pull Requests - develop
 - MAGETWO-83154: [2.3-develop] Order grid - Sort by Purchase Date Desc by default #11931
 - MAGETWO-83101: [Backport 2.3-develop] #8236 FIX CMS blocks #11805
 - MAGETWO-83092: Remove unneeded, also mistyped, saveHandler from CatalogSearch indexer declaration #11626
 - MAGETWO-83091: Remove "Undefined fields" from under lib folder #11662
 - MAGETWO-83083: 10195: Order relation child is not set during edit operation #11909
 - MAGETWO-82998: [2.3-develop] X-Magento-Tags header containing whitespaces causes exception #11849
 - MAGETWO-82633: #11409: Too many password reset requests even when disabled in settings #11434
okorshenko pushed a commit that referenced this issue Nov 3, 2017
@dmanners
MAGETWO-83100: [Backport 2.1-develop] #8236 FIX CMS blocks #11804
abbfc63 
 - Merge Pull Request #11804 from thiagolima-bm/magento2:ISSUE#8236-2.1-develop
 - Merged commits:
   1. 49074ff
   2. 2f1c66c
okorshenko pushed a commit that referenced this issue Nov 3, 2017
MAGETWO-83100: [Backport 2.1-develop] #8236 FIX CMS blocks #11804
0f682e1
okorshenko pushed a commit that referenced this issue Nov 3, 2017
Merge pull request #1658 from magento-engcom/2.1-develop-prs
9bc8f13 
Public Pull Requests

#11804 [Backport 2.1-develop] #8236 FIX CMS blocks by @thiagolima-bm
@sdzhepa sdzhepa mentioned this issue Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagolima-bm thiagolima-bm

Labels
bug report Component: Cms Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@veloraven @thiagolima-bm @okorshenko @magemash @magento-engcom-team @nemesis-back