Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing acl.xml for the Magento_Checkout module #768

Closed
tzyganu opened this issue Nov 24, 2014 · 8 comments
Closed

Missing acl.xml for the Magento_Checkout module #768

tzyganu opened this issue Nov 24, 2014 · 8 comments
Assignees
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Nov 24, 2014

In the system.xml of the Magento_Checkout module there is a resource referenced: <resource>Magento_Checkout::checkout</resource> but the resource is not defined anywhere.
It seams that the acl.xml file is missing.

And a question on the topic. Why is the acl.xml file located directly inside etc folder and not etc/adminhtml since it is used on the admin area alone?

@antonkril
Copy link
Contributor

Resource tree is area agnostic. It can be used by any area. And yes, acl.xml is missing for checkout

@tzyganu
Copy link
Contributor Author

tzyganu commented Nov 24, 2014

@antonkril Thanks for clearing the question.

@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-31329

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed TECH labels Feb 17, 2015
@vpelipenko
Copy link
Contributor

@tzyganu, we've created internal ticket for fixing this issue, but your pull request is always welcome :-).

@pboisvert
Copy link

@asemenenko Andrii--is this one your for checkout or for Piotr (security)?

@tzyganu
Copy link
Contributor Author

tzyganu commented Jun 16, 2016

Any reason why this is not merged yet? Did I do something wrong?

@vkorotun vkorotun removed the PS label Aug 4, 2016
@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

@tzyganu
Copy link
Contributor Author

tzyganu commented Aug 31, 2016

@piotrekkaminski This is not a feature request. It's actually a bug.
I forgot to mention this, maybe because it seamed obvious to me. Now that I think about it it's not that obvious.
Because the acl.xml file is missing in the checkout module, when creating a user role in the backend, I cannot give access to that role to the system->configuration->checkout section.
But anyway...I see that my PR for this made it to the develop branch.
Does this mean it will be available in the next version?
If so, you can leave this closed.

fe-lix- pushed a commit to fe-lix-/magento2 that referenced this issue Apr 6, 2018
Added static test to freeze and allow changes only in particular areas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

9 participants