Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge and minify js - Exception #584

Closed
ihor-sviziev opened this issue Jun 6, 2014 · 2 comments
Closed

Merge and minify js - Exception #584

ihor-sviziev opened this issue Jun 6, 2014 · 2 comments
Assignees
@verklov

Comments

@ihor-sviziev
Copy link
Contributor

When I tried enable in build 2.0.0.0-dev81 enable JS merge and minify - I got exception on frontend and backend:

a:4:{i:0;s:72:"Asset has to implement \Magento\Framework\View\Asset\MergeableInterface.";i:1;s:18863:"#0 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/ObjectManager/Factory/Factory.php(211): Magento\Framework\View\Asset\Merged->__construct(Object(Magento\Framework\Logger), Object(Magento\Framework\View\Asset\MergeStrategy\Checksum), Object(Magento\Framework\View\Asset\Repository), Array)
#1 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/ObjectManager/ObjectManager.php(74): Magento\Framework\ObjectManager\Factory\Factory->create('Magento\\Framewo...', Array)
#2 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Asset/MergeService.php(108): Magento\Framework\ObjectManager\ObjectManager->create('Magento\\Framewo...', Array)
#3 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/View/Asset/MergeService/Interceptor.php(113): Magento\Framework\View\Asset\MergeService->getMergedAssets(Array, 'js')
#4 /Users/igor/vhosts/www/magento2/app/code/Magento/Theme/Block/Html/Head.php(177): Magento\Framework\View\Asset\MergeService\Interceptor->getMergedAssets(Array, 'js')
#5 [internal function]: Magento\Theme\Block\Html\Head->getCssJsHtml()
#6 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/TemplateEngine/Php.php(100): call_user_func_array(Array, Array)
#7 /Users/igor/vhosts/www/magento2/app/code/Magento/Theme/view/frontend/templates/html/head.phtml(32): Magento\Framework\View\TemplateEngine\Php->__call('getCssJsHtml', Array)
#8 /Users/igor/vhosts/www/magento2/app/code/Magento/Theme/view/frontend/templates/html/head.phtml(32): Magento\Framework\View\TemplateEngine\Php->getCssJsHtml()
#9 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/TemplateEngine/Php.php(77): include('/Users/igor/vho...')
#10 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/Template.php(261): Magento\Framework\View\TemplateEngine\Php->render(Object(Magento\Theme\Block\Html\Head), '/Users/igor/vho...', Array)
#11 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/Template.php(281): Magento\Framework\View\Element\Template->fetchView('/Users/igor/vho...')
#12 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/AbstractBlock.php(649): Magento\Framework\View\Element\Template->_toHtml()
#13 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Layout.php(1106): Magento\Framework\View\Element\AbstractBlock->toHtml()
#14 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Layout.php(1082): Magento\Framework\View\Layout->_renderBlock('head')
#15 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/View/Layout/Interceptor.php(243): Magento\Framework\View\Layout->renderElement('head', true)
#16 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/AbstractBlock.php(489): Magento\Framework\View\Layout\Interceptor->renderElement('head', true)
#17 [internal function]: Magento\Framework\View\Element\AbstractBlock->getChildHtml('head')
#18 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/TemplateEngine/Php.php(100): call_user_func_array(Array, Array)
#19 /Users/igor/vhosts/www/magento2/app/code/Magento/Theme/view/frontend/templates/2columns-left.phtml(37): Magento\Framework\View\TemplateEngine\Php->__call('getChildHtml', Array)
#20 /Users/igor/vhosts/www/magento2/app/code/Magento/Theme/view/frontend/templates/2columns-left.phtml(37): Magento\Framework\View\TemplateEngine\Php->getChildHtml('head')
#21 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/TemplateEngine/Php.php(77): include('/Users/igor/vho...')
#22 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/Template.php(261): Magento\Framework\View\TemplateEngine\Php->render(Object(Magento\Theme\Block\Html), '/Users/igor/vho...', Array)
#23 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/Template.php(281): Magento\Framework\View\Element\Template->fetchView('/Users/igor/vho...')
#24 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Element/AbstractBlock.php(649): Magento\Framework\View\Element\Template->_toHtml()
#25 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Layout.php(1106): Magento\Framework\View\Element\AbstractBlock->toHtml()
#26 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Layout.php(1082): Magento\Framework\View\Layout->_renderBlock('root')
#27 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/View/Layout/Interceptor.php(243): Magento\Framework\View\Layout->renderElement('root', true)
#28 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/View/Layout.php(1469): Magento\Framework\View\Layout\Interceptor->renderElement('root')
#29 [internal function]: Magento\Framework\View\Layout->getOutput()
#30 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/View/Layout/Interceptor.php(95): call_user_func_array(Array, Array)
#31 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/View/Layout/Interceptor.php(505): Magento\Framework\View\Layout\Interceptor->___call('getOutput', Array, Array)
#32 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/App/View.php(283): Magento\Framework\View\Layout\Interceptor->getOutput()
#33 /Users/igor/vhosts/www/magento2/app/code/Magento/Catalog/Controller/Category.php(191): Magento\Framework\App\View->renderLayout()
#34 /Users/igor/vhosts/www/magento2/var/generation/Magento/Catalog/Controller/Category/Interceptor.php(113): Magento\Catalog\Controller\Category->viewAction()
#35 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/App/Action/Action.php(124): Magento\Catalog\Controller\Category\Interceptor->viewAction()
#36 [internal function]: Magento\Framework\App\Action\Action->dispatch(Object(Magento\Framework\App\Request\Http))
#37 /Users/igor/vhosts/www/magento2/var/generation/Magento/Catalog/Controller/Category/Interceptor.php(48): call_user_func_array(Array, Array)
#38 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(83): Magento\Catalog\Controller\Category\Interceptor->___callParent('dispatch', Array)
#39 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'lastUrl')
#40 /Users/igor/vhosts/www/magento2/app/code/Magento/Core/App/Action/Plugin/LastUrl.php(79): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#41 [internal function]: Magento\Core\App\Action\Plugin\LastUrl->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#42 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#43 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'designLoader')
#44 /Users/igor/vhosts/www/magento2/app/code/Magento/Core/App/Action/Plugin/Design.php(57): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#45 [internal function]: Magento\Core\App\Action\Plugin\Design->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#46 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#47 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'customer-app-ac...')
#48 /Users/igor/vhosts/www/magento2/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php(75): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#49 [internal function]: Magento\Customer\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#50 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#51 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'contextPlugin')
#52 /Users/igor/vhosts/www/magento2/app/code/Magento/Store/App/Action/Plugin/Context.php(95): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#53 [internal function]: Magento\Store\App\Action\Plugin\Context->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#54 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#55 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'storeCheck')
#56 /Users/igor/vhosts/www/magento2/app/code/Magento/Store/App/Action/Plugin/StoreCheck.php(72): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#57 [internal function]: Magento\Store\App\Action\Plugin\StoreCheck->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#58 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#59 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'catalog-app-act...')
#60 /Users/igor/vhosts/www/magento2/app/code/Magento/Catalog/Model/App/Action/ContextPlugin.php(95): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#61 [internal function]: Magento\Catalog\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#62 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#63 /Users/igor/vhosts/www/magento2/var/generation/Magento/Catalog/Controller/Category/Interceptor.php(88): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Catalog...', 'dispatch', Object(Magento\Catalog\Controller\Category\Interceptor), Array, 'installInitiali...')
#64 /Users/igor/vhosts/www/magento2/app/code/Magento/Install/App/Action/Plugin/Install.php(85): Magento\Catalog\Controller\Category\Interceptor->Magento\Catalog\Controller\Category\{closure}(Object(Magento\Framework\App\Request\Http))
#65 [internal function]: Magento\Install\App\Action\Plugin\Install->aroundDispatch(Object(Magento\Catalog\Controller\Category\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#66 /Users/igor/vhosts/www/magento2/var/generation/Magento/Catalog/Controller/Category/Interceptor.php(93): call_user_func_array(Array, Array)
#67 /Users/igor/vhosts/www/magento2/var/generation/Magento/Catalog/Controller/Category/Interceptor.php(128): Magento\Catalog\Controller\Category\Interceptor->___call('dispatch', Array, Array)
#68 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/App/FrontController.php(62): Magento\Catalog\Controller\Category\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#69 [internal function]: Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#70 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(48): call_user_func_array(Array, Array)
#71 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(83): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#72 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'urlRewrite')
#73 /Users/igor/vhosts/www/magento2/app/code/Magento/UrlRewrite/App/FrontController/Plugin/UrlRewrite.php(71): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#74 [internal function]: Magento\UrlRewrite\App\FrontController\Plugin\UrlRewrite->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#75 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#76 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'requestPreproce...')
#77 /Users/igor/vhosts/www/magento2/app/code/Magento/Store/App/FrontController/Plugin/RequestPreprocessor.php(114): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#78 [internal function]: Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#79 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#80 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'install')
#81 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Module/FrontController/Plugin/Install.php(79): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#82 [internal function]: Magento\Framework\Module\FrontController\Plugin\Install->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#83 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#84 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'dispatchExcepti...')
#85 /Users/igor/vhosts/www/magento2/app/code/Magento/Store/App/FrontController/Plugin/DispatchExceptionHandler.php(71): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#86 [internal function]: Magento\Store\App\FrontController\Plugin\DispatchExceptionHandler->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#87 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#88 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(76): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...')
#89 /Users/igor/vhosts/www/magento2/app/code/Magento/PageCache/Model/App/FrontController/VarnishPlugin.php(79): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}(Object(Magento\Framework\App\Request\Http))
#90 [internal function]: Magento\PageCache\Model\App\FrontController\VarnishPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#91 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/Interception/Chain/Chain.php(81): call_user_func_array(Array, Array)
#92 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(88): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...')
#93 /Users/igor/vhosts/www/magento2/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php(84): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\App\FrontController\{closure}(Object(Magento\Framework\App\Request\Http))
#94 [internal function]: Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#95 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(93): call_user_func_array(Array, Array)
#96 /Users/igor/vhosts/www/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(115): Magento\Framework\App\FrontController\Interceptor->___call('dispatch', Array, Array)
#97 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/App/Http.php(123): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#98 /Users/igor/vhosts/www/magento2/lib/internal/Magento/Framework/App/EntryPoint/EntryPoint.php(80): Magento\Framework\App\Http->launch()
#99 /Users/igor/vhosts/www/magento2/index.php(37): Magento\Framework\App\EntryPoint\EntryPoint->run('Magento\\Framewo...')
#100 {main}";s:3:"url";s:10:"/test.html";s:11:"script_name";s:10:"/index.php";}

I enabled xdebug, and found that exception is fires when $asset is instance of Magento\Framework\View\Asset\Minified

PS: For cache backend using redis
@verklov verklov self-assigned this Jun 13, 2014
@verklov
Copy link
Contributor

verklov commented Jun 13, 2014

@igor-svizev, thank you for reporting this issue! The team will look at the issue. We will get back to you once we finish investigating.

magento-team added a commit that referenced this issue Jul 18, 2014
@magento-team
2.0.0.0-dev87
c8b7223 
* Service layer updates:
  * Created Tax Calculation service
  * Implemented search Tax Rates(search criteria) in TaxRate service
  * Refactored Tax Helper to use Tax Service
  * Validated and ensured that after helper fix, all modules with cross-dependencies use Tax Services
  * Refactored Bundle, Catalog, Checkout, Customer, Downloadable, Review, Logging Modules to use Tax Services
  * Refactored Internal Tax Module Blocks/Templates to use Tax Services
* GitHub requests:
  * [#579] (#579) -- update GA code from ga.js to analytics.js
  * [#584] (#584) -- Merge and minify js - Exception
  * [#585] (#585) -- Add forgotten return statement
  * [#592] (#592) -- Module name pattern
* Tax calculation updates:
  * Separate and display Weee line item totals from Tax
* Fixed bugs:
  * Fixed an issue when Custom attribute template was not applied to a product  during product creation
  * Fixed an issue when report grid with no results contained unnecessary empty "total" section
  * Fixed an issue where MCRYPT_RIJNDAEL_128 Cipher was set instead of 256 version
  * Fixed an issue when inline translate script was always included in the page even if it was not used
  * Fixed an issue where URL Generation was affected by previously processed URLs
  * Fixed an issue with cross-site scripting vulnerability via cookie exploitation
  * Fixed an issue with incorrect success message after system variable was deleted
  * Fixed an issue with category page not opening if it had bundle product with fixed price assigned to it
  * Fixed an issue when subtotal price in a shopping cart was not updated if the product qty is changed
  * Fixed an issue when syntax error appeared while creating new Google Content attribute mapping
  * Fixed an issue with JS error when adding associated simple product to the grouped one
  * Fixed an issue with incorrect items label for the cases when there are more than one item in the category
  * Fixed an issue when configurable product was out of stock in Google Shopping while being in stock in the Magento backend
  * Fixed an issue when swipe gesture in menu widget was not supported on mobile
  * Fixed an issue when it was impossible to enter alpha-numeric zip code on the stage of  estimating shipping and tax rates
  * Fixed an issue when it was impossible to edit gift card account
  * Fixed an issue when custom price was not applied when editing an order
  * Fixed an issue when  items were  not returned to stock after unsuccessful order was placed
  * Fixed an issue when error message appeared "Cannot save the credit memo while creating credit memo
  * Fixed an issue when Catalog price rule was not shown for the product if price was less than a discount
* Indexer implementation:
  * Implemented a new Stock indexer
  * Implemented a new EAV indexer
  * Fixed failed L1 plan on phpunit 4.1.0
  * Minor updates for integration test framework
  * Split action controllers classes into action classes
  * Added public MTF repository to the packagist.org
* Added the following functional tests:
  * Create Admin User
  * Create Category
  * Create Custom Url Rewrite
  * Create Frontend Product Review
  * Delete CMS Page
  * Delete Product
  * Delete System Variable
  * Update Admin User Role
  * Update Product Review
* Indexer-less implementation of URL Rewrites functionality in new UrlRedirect module:
  * Ported Admin UI from old UrlRewrite module
  * Implemented URL Rewrites unified storage
* Covered the following Magento application components with unit tests:
  * `Magento/Bundle/Block/Sales/Order/Items/Renderer.php`
  * `Magento/Bundle/Helper/Catalog/Product/Configuration.php`
  * `Magento/Bundle/Helper/Data.php`
  * `Magento/Bundle/Model/Option.php`
  * `Magento/Bundle/Model/Plugin/PriceBackend.php`
  * `Magento/Bundle/Model/Product/Attribute/Source/Price/View.php`
  * `Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php`
  * `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Enabled.php`
  * `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Price.php`
  * `Magento/Catalog/Model/Product/Visibility.php`
  * `Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php`
  * `Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php`
  * `Magento/Eav/Model/Entity/Attribute/Source/Boolean.php`
  * `Magento/Eav/Model/Entity/Attribute/Source/Table.php`
  * `Magento/Tax/Model/TaxClass/Source/Product.php`
* Covered Magento library with unit tests :
  * `lib/internal/Magento/Framework/Simplexml/Config/Cache/AbstractCache.php`
  * `lib/internal/Magento/Framework/Simplexml/Config.php`
  * `lib/internal/Magento/Framework/Stdlib/DateTime/DateTime.php`
  * `lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php`
  * `lib/internal/Magento/Framework/Stdlib/String.php`
@verklov
Copy link
Contributor

verklov commented Jul 21, 2014

@igor-svizev, the team fixed this issue. We deployed the fix to the GitHub in version dev87. Thank you again for your contribution! We are closing this issue.

@verklov verklov closed this as completed Jul 21, 2014
@verklov verklov mentioned this issue Aug 4, 2014
Closed
@verklov verklov mentioned this issue Sep 5, 2014
Closed
magento-team pushed a commit that referenced this issue Sep 9, 2015
@slavvka
Merge pull request #584 from magento-south/MAGETWO-38562
91eeac1 
[South] Customer - Inline editing + Bug fixes
okorshenko pushed a commit that referenced this issue Feb 7, 2017
Merge pull request #584 from magento-frontend/pr-2.1-develop
bf41d40 
[Frontend] Bugs - for 2.1.x
magento-engcom-team added a commit that referenced this issue Apr 12, 2019
@magento-engcom-team
ENGCOM-4728: graphQl-580: set disabled payment method test coverage #584
70df953 


 - Merge Pull Request magento/graphql-ce#584 from magento/graphql-ce:graphQl-580-set-disabled-payment-method-on-cart-test-coverage
 - Merged commits:
   1. 3f77282
magento-engcom-team pushed a commit that referenced this issue Apr 12, 2019
@naydav
ENGCOM-4728: graphQl-580: set disabled payment method test coverage #584
1791b43
This was referenced Nov 28, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ihor-sviziev @verklov