M2.1 Marketing >> Reviews >> New Review - Sorting & Filters not functioning.

[praful-rajput]

Steps to reproduce

1. Install Magento from "Full Release with Sample Data (ZIP with sample data)" from official page.
2. Logged into admin panel
3. Go to Marketing >> Reviews
4. Click on "New Review" button.
5. It's opening product list grid to select and review it.
6. Grid sorting & Filtering is not working.

Expected result

1. Sorting & Filter should be work over there.

Actual result

1.Sorting & Filtering is not working.

[pboisvert]

Not able to reproduce this issue on 2.1 build.

Screenshot of Marketing > Reviews with default sort on created

Screenshot of Marketing > Reviews with sort by Nickname (shows different order--now alphabetical)

Screenshot of Marketing > Reviews using Filter with keyword on Reviews column

Was this a clean install or an upgrade from previous version? Any other info to provide to help track down the issue?

[praful-rajput]

It was clean install.

Please do not hesitate to reach out with any additional questions or
concerns that you might have.

Regards,

Praful Rajput

On Fri, Jul 1, 2016 at 11:26 PM, Paul Boisvert [email protected]
wrote:

Not able to reproduce this issue on 2.1 build.

Screenshot of Marketing > Reviews with default sort on created
[image: reviews-original]
https://cloud.githubusercontent.com/assets/5807369/16529851/f858598c-3f79-11e6-8f9f-54a1a918459b.png

Screenshot of Marketing > Reviews with sort by Nickname (shows different
order--now alphabetical)
[image: review-sorted-nickname]
https://cloud.githubusercontent.com/assets/5807369/16529859/00f195cc-3f7a-11e6-82dd-38287707d61a.png

Screenshot of Marketing > Reviews using Filter with keyword on Reviews
column
[image: reviews-filtered]
https://cloud.githubusercontent.com/assets/5807369/16529862/0653fef6-3f7a-11e6-8181-ccef106e2894.png

Was this a clean install or an upgrade from previous version? Any other
info to provide to help track down the issue?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5391 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAnmm8xodlnDHErxEFOZ_AEY39SEQ5lMks5qRVTogaJpZM4JC1ri
.

[andimov]

@vasuscoin
Thank you for reporting!
I have reproduced it and created an internal ticket for this issue - MAGETWO-56742 and linked it to this one.

[slavvka]

The fix has been fixed in 2.1 and will be released as a part of future path releases

[Ctucker9233]

@slavvka If we need this fix now, where could we find it?

[slavvka]

@Ctucker9233, try to use the patch:

Index: app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php
===================================================================
diff -u -N -r2d368d0134597257ef5697a4bcbb7f69f2aebed8 -rb80bd55e96f26b745f878169b7ab20af1a0a2a8c
--- app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php   (.../Grid.php)  (revision 2d368d0134597257ef5697a4bcbb7f69f2aebed8)
+++ app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php   (.../Grid.php)  (revision b80bd55e96f26b745f878169b7ab20af1a0a2a8c)
@@ -114,8 +114,6 @@
      */
     protected function _prepareCollection()
     {
-        parent::_prepareCollection();
-
         $store = $this->_getStore();
         $collection = $this->_productFactory->create()->getCollection()->addAttributeToSelect(
             'sku'
@@ -184,6 +182,9 @@
         $this->setCollection($collection);

         $this->getCollection()->addWebsiteNamesToResult();
+
+        parent::_prepareCollection();
+
         return $this;
     }

[Ctucker9233]

@slavvka Forgive my noob question, but how do I use this patch? I am not using composer to update off of the github repo. Can I simply manually add the changes to the files?

[slavvka]

@Ctucker9233 yes you can