BeforeOrderPaymentSaveObserver override payment insructions with wrong store view config

[bernd-reindl]

Preconditions (*)

Magento 2.3.3
2 StoreViews

Steps to reproduce (*)

1. Create a second Store View
2. Set a value to bankpayment instructions (e.g. Instructions)
3. Set a other value to bankpayment instructions for the second storeview (e.g. Anweisungen)
4. Create an order in second storeview (frontend) with bankpayment als payment method
5. See field 'additional_information' in table 'sales_order_payment' -> contains value of secons storeview for instructions
6. Create an invoice for the order
7. See field 'additional_information' in table 'sales_order_payment' -> contains value of default storeview for instructions

Expected result (*)

1. Payment instructions should used from order store view

Actual result (*)

1. Payment instructions are used from default store view
2. If BeforeOrderPaymentSaveObserver was disabled, the payment instructions get preserved
3. So BeforeOrderPaymentSaveObserver should respect the order store view for fetching payment instructions

default store view

second store view

sales_order_payment

[m2-assistant]

Hi @bernd-reindl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@bernd-reindl do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[bernd-reindl]

yes i confirm

[rommelfreddy]

can confirm it too.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[bernd-reindl]

How can i add the Label Issue: Confirmed???

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-30383 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @karyna-tsymbal-atwix. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[slavvka]

Hi @bernd-reindl. Thank you for your report.
The issue has been fixed in #26399 by @karyna-tsymbal-atwix in 2.4-develop branch
Related commit(s):

• 364b51a08021abd491e89f9ec838e78476420ab0

The fix will be available with the upcoming 2.4.0 release.