Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitespace between label and required star on Checkout page #26275

Closed
tejash-wagento opened this issue Jan 6, 2020 · 20 comments
Closed

Whitespace between label and required star on Checkout page #26275

tejash-wagento opened this issue Jan 6, 2020 · 20 comments
Assignees
@tejash-wagento
Labels
Component: Checkout Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@tejash-wagento
Copy link
Contributor

tejash-wagento commented Jan 6, 2020 •
edited
Loading

Summary

Whitespace between the label and required star on the Checkout page

Preconditions

  1. Magento 2x - This issue reproduce in all version.

Steps to reproduce

  1. Add simple product in the cart
  2. Go to checkout page

Expected result

image

Actual result

image
@tejash-wagento tejash-wagento self-assigned this Jan 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2020 •
edited by tejash-wagento
Loading

Hi @tejash-wagento. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@tejash-wagento do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2020 •
edited by tejash-wagento
Loading

Hi @tejash-wagento. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jan 6, 2020
@ajijshekh123 ajijshekh123 self-assigned this Jan 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2020

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jan 6, 2020
@tejash-wagento
Copy link
Contributor Author

I am working on this

@ajijshekh123
Copy link

Okay @tejash-wagento, Let me verify and confirm the issue.

@ajijshekh123
Copy link

Why @tejash-wagento , You have to unassigned to me?

@tejash-wagento tejash-wagento changed the title Whitespace between lable and required star on Checkout page Whitespace between label and required star on Checkout page Jan 6, 2020
@krishprakash krishprakash self-assigned this Jan 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2020 •
edited by krishprakash
Loading

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-26275-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added Component: Checkout Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jan 6, 2020
@ghost ghost unassigned krishprakash Jan 6, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 6, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-30219 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@dmytro-ch
Copy link
Contributor

Hi @tejash-wagento,
please create the pull requests with minor fixes and obvious improvements without opening the issues.
Thank you!

@dmytro-ch dmytro-ch added non-issue and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 6, 2020
@dmytro-ch dmytro-ch removed the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 6, 2020
@tejash-wagento
Copy link
Contributor Author

Hi @dmytro-ch,
How can I improvements without opening the issues,
Please suggest?

@DanielRuf
Copy link
Contributor

You can always create a PR, an issue is not required and produces more work for involved people.

@tejash-wagento
Copy link
Contributor Author

tejash-wagento commented Jan 7, 2020 •
edited
Loading

Hi @DanielRuf,
I have not created PR a long time, I have created my last PR 2 years ago at Jul 30, 2018.
So I am not always creating a PR, an issue is not required and produces more work for involved people.

Please check my PR history and comment.

@DanielRuf
Copy link
Contributor

Not sure why people downvote.
As @dmytro-ch wrote:

Hi @tejash-wagento,
please create the pull requests with minor fixes and obvious improvements without opening the issues.
Thank you!

So just go ahead and create a PR with the fixes.

@DanielRuf
Copy link
Contributor

To quote yourself:

#26275 (comment)

I am working on this

It was assigned to @ajijshekh123 and others who were working on it.

@DanielRuf
Copy link
Contributor

Interesting, 4 people from wagento downvoting for no obvious reasons (read the previous comments).

If you need help with the PR just let us know.

@DanielRuf DanielRuf mentioned this issue Jan 7, 2020
Merged
4 tasks
@DanielRuf
Copy link
Contributor

There you go: #26285

Please be more polite next time and downvoting is never helpful (without further feedback) =)

Also related: #16048

Please keep in mind that at least two people (excluding you) were working on this. Please give them the chance to do the chances then when the issue is assigned to them. Unassigning them is not very nice. If you intend to fix it yourself please do so without creating a separate issue to prevent such cases in the future.

@slavvka
Copy link
Member

slavvka commented Feb 7, 2020

Hi @tejash-wagento. Thank you for your report.
The issue has been fixed in #26285 by @DanielRuf in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 7, 2020
magento-engcom-team added a commit that referenced this issue Feb 7, 2020
@magento-engcom-team
ENGCOM-6581: Remove extraneous whitespace - #26275 #26285
a9b473d 
 - Merge Pull Request #26285 from DanielRuf/magento2:fix/26275-checkout-required-fields-remove-space
 - Merged commits:
   1. d9a4bca
   2. 51f4964
   3. 574f052
   4. 0edeb06
   5. fb208a8
   6. c1c363f
   7. 98e1159
   8. 10cc12a
   9. ff4ead5
   10. 535b7c8
   11. 4b86376
   12. 3165046
   13. 66a76f3
   14. ca19b06
   15. 60b7f1c
   16. 1eed0f1
   17. 5958409
   18. 4b9b6fa
magento-engcom-team pushed a commit that referenced this issue Feb 7, 2020
@slavvka
ENGCOM-6581: Remove extraneous whitespace - #26275 #26285
0850e5e
@sdzhepa sdzhepa mentioned this issue May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejash-wagento tejash-wagento

Labels
Component: Checkout Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@DanielRuf @sdzhepa @slavvka @dmytro-ch @tejash-wagento @ajijshekh123 @magento-engcom-team @krishprakash