Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Export rendered data is not reflecting in the exported File, Displayed ID instead of Rendered Label #25963

Closed
koushikch7 opened this issue Dec 10, 2019 · 15 comments
Assignees
Labels
Component: ImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@koushikch7
Copy link

koushikch7 commented Dec 10, 2019

Preconditions

Verified in Magento 2.3.2 and 2.3.3 and found that the data displayed in the grid by rendering columns is not reflecting in the Exported file, Instead, we are getting Id of the data rather than grid value.
Verified in the environments,

  1. Magento 2.3.2 and Magento 2.3.3 & 2.4-develop
  2. Apache and Nginx
  3. Mysql and MongoDB

Steps to reproduce

  1. Log in to the Magento Admin
  2. Choose any grid having an export option. In my case, I choose for Sales Order Grid.
  3. Click on Export using CSV/Excel.

Expected result

CSV/Excel sheet that contains all the details with values as displayed in the grid
e.g.:
image

Actual result

CSV/Excel sheet that contains Columns with ID rathe than values displayed as in the grid
export

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @koushikch7. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@koushikch7 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Dec 10, 2019
@tuyennn
Copy link
Member

tuyennn commented Dec 10, 2019

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn, here is your Magento instance.
Admin access: https://i-25963-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Charlie engcom-Charlie self-assigned this Dec 12, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie engcom-Charlie added Component: ImportExport good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 12, 2019
@ghost ghost unassigned engcom-Charlie Dec 12, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-29734 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 12, 2019
@konarshankar07 konarshankar07 self-assigned this Dec 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2019

Hi @konarshankar07. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@koushikch7
Copy link
Author

@konarshankar07 This issue is not only for the Customer group grid, but also for the all grids (Default and Custom) which need fixed globally not like everywhere i think.

@koushikch7
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @koushikch7. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @koushikch7, here is your Magento instance.
Admin access: https://i-25963-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@koushikch7
Copy link
Author

@magento give me 2.3.2 instance

@magento-engcom-team
Copy link
Contributor

Hi @koushikch7. Thank you for your request. I'm working on Magento 2.3.2 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @koushikch7, here is your Magento instance.
Admin access: https://i-25963-2-3-2.instances.magento-community.engineering/admin_cc6b
Login: c3da96b8 Password: 34e7a9268dff
Instance will be terminated in up to 3 hours.

@novikor novikor added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed good first issue labels Jan 23, 2020
novikor added a commit that referenced this issue Jan 24, 2020
…played ID instead of Rendered Label #25963.

Fixed grids export: option labels are taken from grid filters and columns now.
@ghost ghost assigned novikor Jan 24, 2020
novikor added a commit to novikor/magento2 that referenced this issue Jan 24, 2020
…played ID instead of Rendered Label magento#25963.

Implemented strict types.
novikor added a commit to novikor/magento2 that referenced this issue Jan 24, 2020
…played ID instead of Rendered Label magento#25963.

Fixed case when options are configured via XML directly instead of providing a class.
novikor added a commit to novikor/magento2 that referenced this issue Jan 30, 2020
…played ID instead of Rendered Label magento#25963.

Fixed Unit tests.
novikor added a commit to novikor/magento2 that referenced this issue Jan 30, 2020
…played ID instead of Rendered Label magento#25963.

Unit tests code reformatting.
novikor added a commit to novikor/magento2 that referenced this issue Jan 30, 2020
…played ID instead of Rendered Label magento#25963.

Implemented Unit tests coverage.
novikor added a commit to novikor/magento2 that referenced this issue Jan 31, 2020
…played ID instead of Rendered Label magento#25963.

Removed deprecated class.
novikor added a commit to novikor/magento2 that referenced this issue Jan 31, 2020
…played ID instead of Rendered Label magento#25963.

Removed deprecated class.
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 21, 2020
magento-engcom-team added a commit that referenced this issue Feb 21, 2020
…m grid filters and columns now. #26523

 - Merge Pull Request #26523 from novikor/magento2:25963-grid-export-labels
 - Merged commits:
   1. b43980b
   2. 93793d8
   3. c517f5f
   4. 9bb416f
   5. cd24e41
   6. 6b434ba
   7. b117b0c
   8. 4a78ca5
   9. 34d1876
   10. 4483911
   11. 0d3e478
   12. 1a1ab4d
   13. 5849cb6
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

6 participants