Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese input in tinymce 4 #24637

Closed
Consumewithadele opened this issue Sep 18, 2019 · 10 comments
Closed

Chinese input in tinymce 4 #24637

Consumewithadele opened this issue Sep 18, 2019 · 10 comments
Assignees
Labels
Component: Framework/Wysiwyg Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Consumewithadele
Copy link

Consumewithadele commented Sep 18, 2019

Preconditions (*)

  1. Magento CE 2.3.0, 2.3.2 & 2.3-develop
  2. Problem exist with this language packs and more:
    image

Steps to reproduce (*)

  1. Go to admin and open new product page.
  2. Open content tab to see wysiwyg editor.
  3. Switch keyboard to Chinese
  4. Start type any Chinese text in wysiwyg editor.

Expected result (*)

  1. System autocomplete popup for Chinese should work as expected.

Actual result (*)

  1. Looks like autocomplete popup for Chinese looses focus, navigation within autocomplete doesn't work.

Additional notices:
problem caused by
lib/web/mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter.js
fixRangeSelection: function (editor) {} . If I comment call of this function, CN input works well.

If I switch wysiwyg to tinymce 3 in magento system configuration, CN input works well.

Additional question.
fixRangeSelection: function (editor) {}
has comment:
/**
* Fix range selection placement when typing. This fixes MAGETWO-84769
* @param {Object} editor
*/

@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2019

Hi @Consumewithadele. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Consumewithadele do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 18, 2019
@engcom-Charlie engcom-Charlie self-assigned this Sep 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie
Copy link
Contributor

Hello @Consumewithadele !
We can't reproduce this issue on Magento 2.3.2 & 2.3-develop.

Manual testing scenario:

  1. Go to admin and open new product page.
  2. Open content tab to see wysiwyg editor.
  3. Switch keyboard to Chinese
  4. Start type any Chinese text in wysiwyg editor.

Actual result:
Two Chinese fonts works:
image

image

So i have to close this issue.
Thanks for your report!

@Consumewithadele
Copy link
Author

Hello,
Could you share information about bug MAGETWO-84769 ?

Could you check attached video where you can see strange behaviour during CN input ?
CN_input.mov.zip

@engcom-Charlie
Copy link
Contributor

@Consumewithadele After watching your video i tested with another languages and i reproduced this issue. This problem exist with this packs:
image
So excuse me about closing this issue.
Sorry but i can't share information about MAGETWO-84769.

@ghost ghost unassigned engcom-Charlie Sep 20, 2019
@engcom-Charlie engcom-Charlie self-assigned this Sep 20, 2019
@engcom-Charlie engcom-Charlie added Component: Framework/Wysiwyg Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 20, 2019
@ghost ghost unassigned engcom-Charlie Sep 20, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-20293 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 20, 2019
@HirokazuNishi
Copy link
Contributor

It's not only Chinese, but also Japanese.

@HirokazuNishi HirokazuNishi self-assigned this Oct 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2019

Hi @HirokazuNishi. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@sidolov
Copy link
Contributor

sidolov commented Oct 21, 2019

Hi @HirokazuNishi , mentioned issue details:

Steps to reproduce:

  1. Insert a widget into the editor
  2. Add text with no spaces
  3. Insert another widget after text with no spaces

Example:
TEXT

Expected result:
widget gets inserted after the text and text is still editable

Actual result:
widget gets inserted before the text and text is no longer editable

HirokazuNishi added a commit to Veriteworks/magento2 that referenced this issue Nov 4, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @Consumewithadele. Thank you for your report.
The issue has been fixed in #25454 by @HirokazuNishi in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Wysiwyg Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants