URL Rewrites redirect loop #20309

mrmoonlv · 2019-01-15T12:36:45Z

Preconditions (*)

PHP 7.1
Magento version 2.2.6

Steps to reproduce (*)

Go To Admin Url rewrites.
Create New Url rewrite with request-path: / and target_path / with 301 or 302 redirect./

Expected result (*)

Validation errors, that there will be infinite redirecion loop

Actual result (*)

Browser error:
This page isn’t working. redirected you too many times.
Try clearing your cookies.
ERR_TOO_MANY_REDIRECTS

magento-engcom-team · 2019-01-15T12:36:48Z

Hi @mrmoonlv. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@mrmoonlv do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

magento-engcom-team · 2019-01-15T12:38:03Z

Hi @SikailoISM. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

ghost · 2019-01-15T12:38:18Z

@magento-engcom-team give me 2.2.6 instance

magento-engcom-team · 2019-01-15T12:38:22Z

Hi @SikailoISM. Thank you for your request. I'm working on Magento 2.2.6 instance for you

magento-engcom-team · 2019-01-15T12:38:51Z

Hi @SikailoISM, here is your Magento instance.
Admin access: https://i-20309-2-2-6.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team · 2019-01-15T12:40:47Z

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team · 2019-01-15T12:40:58Z

Hi @Surabhi-Cedcoss. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

ghost · 2019-01-15T12:42:32Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-01-15T12:42:32Z

Hi @SikailoISM. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-01-15T12:43:26Z

Hi @SikailoISM, here is your Magento instance.
Admin access: https://i-20309-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team · 2019-01-15T12:45:38Z

@SikailoISM Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97640, MAGETWO-97641 were created

orlangur · 2019-01-15T20:21:37Z

@mrmoonlv @SikailoISM system works correctly as per configuration, what could be the reason to specify such request and target path?

mrmoonlv · 2019-01-16T07:55:22Z

@orlangur, Yes: “system works correctly as per configuration”, but:

Fot configuration where request pahts == target paths, no dev user can break a whole webpage with never ending redirection loop.

Ofcourse: no one systems isnt secure to prevent foolish secure UX

m2-assistant · 2019-11-29T09:02:50Z

Hi @mautz-et-tong. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

This adds a meaningful exception if request path equals target path on url rewrite edit page in admin

…gration test cases

magento-engcom-team · 2020-03-12T04:25:33Z

Hi @mrmoonlv. Thank you for your report.
The issue has been fixed in #26902 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

- Merge Pull Request #26902 from Bartlomiejsz/magento2:feature/fix_20309_url_rewrites_redirect_loop - Merged commits: 1. 684b951 2. 0fd6fd3

chamarts · 2020-03-22T10:11:33Z

whats temporary fix for this ?

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 15, 2019

ghost self-assigned this Jan 15, 2019

ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: UrlRewrite labels Jan 15, 2019

shikhamis11 self-assigned this Jan 15, 2019

surabhisrivastava09 self-assigned this Jan 15, 2019

ghost added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Jan 15, 2019

ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 15, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 15, 2019

ghost mentioned this issue Jan 15, 2019

Fix: URL Rewrites redirect loop [2.3] #20313

Closed

4 tasks

shikhamis11 removed their assignment Jan 15, 2019

orlangur added the Progress: needs update label Jan 15, 2019

ghost removed their assignment May 17, 2019

ghost unassigned surabhisrivastava09 Sep 27, 2019

mautz-et-tong self-assigned this Nov 29, 2019

mautz-et-tong added Component: Backend Event: cd-cologne19 labels Nov 29, 2019

mautz-et-tong pushed a commit to mautz-et-tong/magento2 that referenced this issue Nov 29, 2019

[FIXES] magento#20309: URL Rewrites redirect loop

1b20d93

This adds a meaningful exception if request path equals target path on url rewrite edit page in admin

mautz-et-tong mentioned this issue Nov 29, 2019

[FIXES] #20309: URL Rewrites redirect loop #25848

Closed

4 tasks

ghost unassigned mautz-et-tong Jan 14, 2020

Bartlomiejsz mentioned this issue Feb 17, 2020

Fix #20309 - URL Rewrites redirect loop #26902

Merged

4 tasks

ghost assigned Bartlomiejsz Feb 17, 2020

Bartlomiejsz linked a pull request Feb 17, 2020 that will close this issue

Fix #20309 - URL Rewrites redirect loop #26902

Merged

4 tasks

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Feb 18, 2020

Fix magento#20309 - URL Rewrites redirect loop

684b951

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Feb 26, 2020

Fix magento#20309 - fix url rewrite check with query params, add inte…

0fd6fd3

…gration test cases

magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2020

magento-engcom-team closed this as completed Mar 12, 2020

magento-engcom-team added a commit that referenced this issue Mar 12, 2020

ENGCOM-6995: Fix #20309 - URL Rewrites redirect loop #26902

a12d705

- Merge Pull Request #26902 from Bartlomiejsz/magento2:feature/fix_20309_url_rewrites_redirect_loop - Merged commits: 1. 684b951 2. 0fd6fd3

magento-engcom-team pushed a commit that referenced this issue Mar 12, 2020

ENGCOM-6995: Fix #20309 - URL Rewrites redirect loop #26902

7ee65f0

github-jira-sync-bot added Progress: done and removed Progress: needs update labels Feb 22, 2021

This was referenced May 9, 2022

tyutyu sdzhepa/magento2#5

Open

2.4.0 Fast White Cat sdzhepa/magento2#10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

URL Rewrites redirect loop #20309

URL Rewrites redirect loop #20309

mrmoonlv commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019 •

edited by ghost

Loading

ghost commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019 •

edited by shikhamis11

Loading

magento-engcom-team commented Jan 15, 2019

ghost commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

orlangur commented Jan 15, 2019

mrmoonlv commented Jan 16, 2019

m2-assistant bot commented Nov 29, 2019

magento-engcom-team commented Mar 12, 2020

chamarts commented Mar 22, 2020

URL Rewrites redirect loop #20309

URL Rewrites redirect loop #20309

Comments

mrmoonlv commented Jan 15, 2019

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019 • edited by ghost Loading

ghost commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019 • edited by shikhamis11 Loading

magento-engcom-team commented Jan 15, 2019

ghost commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

magento-engcom-team commented Jan 15, 2019

orlangur commented Jan 15, 2019

mrmoonlv commented Jan 16, 2019

m2-assistant bot commented Nov 29, 2019

magento-engcom-team commented Mar 12, 2020

chamarts commented Mar 22, 2020

magento-engcom-team commented Jan 15, 2019 •

edited by ghost

Loading

magento-engcom-team commented Jan 15, 2019 •

edited by shikhamis11

Loading