Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento 2.2.2 text swatch switches product image even if attribute feature is disabled #16446

Closed
LouNik1984 opened this issue Jun 28, 2018 · 10 comments
Assignees
Labels
Component: Swatches Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@LouNik1984
Copy link

Preconditions

magento 2.2.2 with one website and two store views
php 7.0 on ubuntu 16.04 with nginx

Steps to reproduce

  • change attribute size to text swatch with Update Product Preview Image set to NO
  • create configurable product with some variations for size
  • add image to configurable product
  • add image to associated simple products

Expected result

When I load the frontend product page, the image shown is the configurable image.
When I click on a size/variation (since the Update Product Preview Image set to NO in attribute size) I still expect to see the configurable image

Actual result

When I load the frontend product page, the image shown is the configurable image. That is correct.
When I click on a size/variation, the image is changed to the simple product image. This is wrong.

Other Notes

If I remove the image from the associated simple product, then go to the frontend product page and click on the size, the image shown is still the configurable image. However, the image is still being reloaded everytime I click on a size/variation, making the page glitch for a moment. This should be avoided.

@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@LouNik1984 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 28, 2018
@LouNik1984
Copy link
Author

@magento-engcom-team give me 2.2.2 instance

@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your request. I'm working on Magento 2.2.2 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984, here is your Magento instance.
Admin access: https://i-16446-2-2-2.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@LouNik1984
Copy link
Author

LouNik1984 commented Jun 28, 2018

I confirm I can reproduce the issue on the vanilla Magento instance you provided me.

What I did on the vanilla instance

  • I created a new category to have a link to the product on the frontend
  • I created an attribute called size with attribute code size, type = text swatch and option "Update Product Preview Image" se to NO
  • I edited the Default attribute set to add the new size attribute
  • I created a configurable product with 3 size variations (small, medium, large)
  • I added an image to all the products, both the configurable and the associated simple products

Result

If you go to the frontend product page https://i-16446-2-2-2.engcom.dev.magento.com/test-product.html and click on the different configurations/text swatches, you can see that the image is loaded every time you click on a variation even if the attribute size is set to "Update Product Preview Image" = NO

@ghost ghost self-assigned this Jul 2, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Swatches labels Jul 2, 2018
@ghost
Copy link

ghost commented Jul 2, 2018

Hello @LouNik1984, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Jul 2, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 20, 2018
@ravi-chandra3197 ravi-chandra3197 self-assigned this Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-assistant
Copy link

m2-assistant bot commented Apr 7, 2019

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your report.
The issue has been fixed in #19184 by @ravi-chandra3197 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

magento-engcom-team added a commit to okorshenko/magento2 that referenced this issue Jun 7, 2019
… attribute feature is disabled magento#16446 magento#19184

 - Merge Pull Request magento#19184 from ravi-chandra3197/magento2:patch-16446
 - Merged commits:
   1. dfaee8e
   2. 6ce2026
   3. 01e8ff1
   4. 73ef119
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue Jun 7, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your report.
The issue has been fixed in #22510 by @ravi-chandra3197 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Swatches Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants