Checkout/Cart visit results in error (500) after update 2.2.1 -> 2.2.2 #12655

fwolfst · 2017-12-12T20:51:32Z

Preconditions

Using magento 2.2.2 (updated from 2.2.1), none of the new features.
php, mysql and other libraries current from vanilla ubuntu 16.04

Steps to reproduce

Populate cart, visist https://shop/checkout/cart

Expected result

Get served a cart page as in magento 2.2.1

Actual result

Magento answers with a snippet of shipping stuff (in our case translated "Versandgebühren hier abrufen") in a block-shipping div nicely wrapped in a HTTP 500 response.
The log shows:

2017/12/12 20:56:09 [error] 13026#13026: *1925924 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Magento\Quote\Model\Cart\Totals::setExtensionAttributes() must be an instance of Magento\Quote\Api\Data\TotalsExtensionInterface, instance of Magento\Quote\Api\Data\AddressExtension given, called in /var/www/XXX/vendor/magento/framework/Api/DataObjectHelper.php on line 125 and defined in /var/www/XXX/vendor/magento/module-quote/Model/Cart/Totals.php:592
Stack trace:
#0 /var/www/XXX/vendor/magento/framework/Api/DataObjectHelper.php(125): Magento\Quote\Model\Cart\Totals->setExtensionAttributes(Object(Magento\Quote\Api\Data\AddressExtension))
#1 /var/www/XXX/vendor/magento/framework/Api/DataObjectHelper.php(85): Magento\Framework\Api\DataObjectHelper->_setDataValues(Object(Magento\Quote\Model\Cart\Totals), Array, 'Magento\\Quote\\A...')
#2 /var/www/XXX/vendor/magento/module-quote/Model/Cart/CartTotalRepository.php(103): Magento\Framework\Api\DataObjectHelper->popu" while reading response header from upstream, client: 127.0.0.1, server: XXX, request: "GET /checkout/cart/ HTTP/1.0", upstream: "fastcgi://unix:/var/run/php/php7.0-fpm.sock:", host: "XXX", referrer: "https://XXX/myproduct.html"

The text was updated successfully, but these errors were encountered:

fwolfst · 2017-12-12T21:43:24Z

This only happens if there are items in cart, once I delete them I see again a happy "empty cart"- kind of page. And not reproducibly so (well - only in a new incognito browser window it works fine).

webazad · 2017-12-15T00:04:02Z

Facing same problem

darinda · 2017-12-15T06:52:08Z

I can confirm the same problem arising on my magento2 installation after upgrading from 2.2.1 to 2.2.2. Downgrading back to 2.2.1 fixes the problem.

wilzon008 · 2017-12-15T16:36:01Z

I am having the same issue as well.

friimaind · 2017-12-21T09:57:06Z

I am having the same issue.

Magento 2.2.2 upgraded from 2.1.9

Happens with new or logged customers

Apache error log:

PHP Fatal error: Uncaught TypeError: Argument 1 passed to Magento\\Quote\\Model\\Cart\\Totals::setExtensionAttributes() must be an instance of Magento\\Quote\\Api\\Data\\TotalsExtensionInterface, instance of Magento\\Quote\\Api\\Data\\AddressExtension given, called in /var/www/www.mywebsite.com/public_html/vendor/magento/framework/Api/DataObjectHelper.php on line 125 and defined in /var/www/www.mywebsite.com/public_html/vendor/magento/module-quote/Model/Cart/Totals.php:592\nStack trace:\n#0 /var/www/www.mywebsite.com/public_html/vendor/magento/framework/Api/DataObjectHelper.php(125): Magento\\Quote\\Model\\Cart\\Totals->setExtensionAttributes(Object(Magento\\Quote\\Api\\Data\\AddressExtension))\n#1 /var/www/www.mywebsite.com/public_html/vendor/magento/framework/Api/DataObjectHelper.php(85): Magento\\Framework\\Api\\DataObjectHelper->_setDataValues(Object(Magento\\Quote\\Model\\Cart\\Totals), Array, 'Magento\\\\Quote\\\\A...')\n#2 /var/www/www.mywebsite.com/public_html/vendor/magento/module-quote/Model/Cart/CartTotalRepository.php(103): Magento\\F in /var/www/www.mywebsite.com/public_html/vendor/magento/module-quote/Model/Cart/Totals.php on line 592, referer: https://www.mywebsite.com/it/checkout/

twa8000 · 2017-12-23T04:17:33Z

Same issue. Only happens when your logged into a customer account with items in your cart.

cmuench · 2017-12-29T14:27:21Z

I have this issue also if a payment failed after the customer returns to the cart page.

mombrea · 2017-12-29T15:42:08Z

I have this issue after upgrading to 2.2.2 as well. Only happens for logged in users. Creating a new user account works for a time and then starts failing.

With PHP errors on the last output is:

window.checkoutConfig = <br />
--
  | <b>Fatal error</b>:  Uncaught TypeError: Argument 1 passed to Magento\Quote\Model\Cart\Totals::setExtensionAttributes() must be an instance of Magento\Quote\Api\Data\TotalsExtensionInterface, instance of Magento\Quote\Api\Data\AddressExtension given, called in /var/www/clients/client3/web4/web/vendor/magento/framework/Api/DataObjectHelper.php on line 125 and defined in /var/www/clients/client3/web4/web/vendor/magento/module-quote/Model/Cart/Totals.php:592
  | Stack trace:
  | #0 /var/www/clients/client3/web4/web/vendor/magento/framework/Api/DataObjectHelper.php(125): Magento\Quote\Model\Cart\Totals-&gt;setExtensionAttributes(Object(Magento\Quote\Api\Data\AddressExtension))
  | #1 /var/www/clients/client3/web4/web/vendor/magento/framework/Api/DataObjectHelper.php(85): Magento\Framework\Api\DataObjectHelper-&gt;_setDataValues(Object(Magento\Quote\Model\Cart\Totals), Array, 'Magento\\Quote\\A...')
  | #2 /var/www/clients/client3/web4/web/vendor/magento/module-quote/Model/Cart/CartTotalRepository.php(103): Magento\Framework\Api\DataObjectHelper-&gt;populateW in <b>/var/www/clients/client3/web4/web/vendor/magento/module-quote/Model/Cart/Totals.php</b> on line <b>592</b><br />

Downgrading to 2.2.1 solved the problem.

JonnyStecchino · 2018-01-02T12:10:27Z

I am having the same issue.
Magento 2.2.2 upgraded from 2.1.10

bydrei · 2018-01-04T16:43:24Z

@JonnyStecchino, @mombrea, @friimaind, @fwolfst, @cmuench, @twa8000, @webazad, @darinda This was an issue which had been fixed since 2.1.7 but for some reason it was not merged to 2.2.*. Here is the fix for it aa535e.

I've created a temporary plugin to fix this, so you could also do the same.

fwolfst · 2018-01-06T16:22:09Z

@ferrazzuk Awesome. confirm that fix works.

keywoker · 2018-01-11T13:19:26Z

@ferrazzuk Hello, Can you add code of your plugin or link ?

artklassen · 2018-01-22T23:02:04Z

Hello,
I am using Magento 2.2.2 installed from scratch, not updated from earlier version. I am still experiencing same issue. I tried this fix aa535e it doesn't help.

Uncaught TypeError: Argument 1 passed to Magento\Quote\Model\Cart\Totals::setExtensionAttributes() must be an instance of Magento\Quote\Api\Data\TotalsExtensionInterface, instance of Magento\Quote\Api\Data\AddressExtension given, called in /home/reachf90/public_html/dev18/vendor/magento/framework/Api/DataObjectHelper.php on line 125 and defined in /home/reachf90/public_html/dev18/vendor/magento/module-quote/Model/Cart/Totals.php:592 Stack trace: #0 /home/reachf90/public_html/dev18/vendor/magento/framework/Api/DataObjectHelper.php(125): Magento\Quote\Model\Cart\Totals->setExtensionAttributes(Object(Magento\Quote\Api\Data\AddressExtension)) #1 /home/reachf90/public_html/dev18/vendor/magento/framework/Api/DataObjectHelper.php(85): Magento\Framework\Api\DataObjectHelper->_setDataValues(Object(Magento\Quote\Model\Cart\Totals), Array, 'Magento\\Quote\\A...') #2 /home/reachf90/public_html/dev18/vendor/magento/module-quote/Model/Cart/CartTotalRepository.php(103): Magento\Framework\Api\DataObjectHelper->populateWithAr in /home/reachf90/public_html/dev18/vendor/magento/module-quote/Model/Cart/Totals.php on line 592 {"messages":{"error":[{"code":500,"message":"Fatal Error: 'Uncaught TypeError: Argument 1 passed to Magento\\Quote\\Model\\Cart\\Totals::setExtensionAttributes() must be an instance of Magento\\Quote\\Api\\Data\\TotalsExtensionInterface, instance of Magento\\Quote\\Api\\Data\\AddressExtension given, called in \/home\/reachf90\/public_html\/dev18\/vendor\/magento\/framework\/Api\/DataObjectHelper.php on line 125 and defined in \/home\/reachf90\/public_html\/dev18\/vendor\/magento\/module-quote\/Model\/Cart\/Totals.php:592\nStack trace:\n#0 \/home\/reachf90\/public_html\/dev18\/vendor\/magento\/framework\/Api\/DataObjectHelper.php(125): Magento\\Quote\\Model\\Cart\\Totals->setExtensionAttributes(Object(Magento\\Quote\\Api\\Data\\AddressExtension))\n#1 \/home\/reachf90\/public_html\/dev18\/vendor\/magento\/framework\/Api\/DataObjectHelper.php(85): Magento\\Framework\\Api\\DataObjectHelper->_setDataValues(Object(Magento\\Quote\\Model\\Cart\\Totals), Array, 'Magento\\\\Quote\\\\A...')\n#2 \/home\/reachf90\/public_html\/dev18\/vendor\/magento\/module-quote\/Model\/Cart\/CartTotalRepository.php(103): Magento\\Framework\\Api\\DataObjectHelper->populateWithAr' in '\/home\/reachf90\/public_html\/dev18\/vendor\/magento\/module-quote\/Model\/Cart\/Totals.php' on line 592","trace":"Trace is not available."}]}}

OwenMelbz · 2018-02-06T10:22:21Z

Is there an estimated time for fix and release on this as its a pretty large issue, clearly affecting many people?

Thanks

flancer64 · 2018-02-16T09:09:26Z

I had the same issue and I have created a standalone magento module flancer32/mage2_fix_is12655 based on aa535e to fix it.

magento-engcom-team · 2018-02-16T11:30:06Z

@fwolfst, thank you for your report.
We've acknowledged the issue and added to our backlog.

Sil-B · 2018-02-22T09:12:23Z

We are facing the same issues on upgrade from m2.2.1 -> m2.2.2.
The module of @flancer64 works for me! Thanks

njbair · 2018-02-22T20:35:04Z

Another confirmation that the issue exists and that @flancer64 's fix works perfectly.

al1357 · 2018-03-08T11:00:44Z

In my case the issue appeared after update from 2.1.9 to 2.2.3, @flancer64 's fix worked.

fluential · 2018-03-08T23:02:22Z

Same issue here with 2.2.1 -> 2.2.3 @flancer64 is a star!

vbuck · 2018-03-09T22:25:21Z

Same issue here. Upon a closer look, I found some behavior in \Magento\Checkout\Model\TotalsInformationManagement that did not align with similar procedures in the quote module. See excerpt from this class below:

/**
 * {@inheritDoc}
 */
public function calculate(
    $cartId,
    \Magento\Checkout\Api\Data\TotalsInformationInterface $addressInformation
) {
    /** @var \Magento\Quote\Model\Quote $quote */
    $quote = $this->cartRepository->get($cartId);
    $this->validateQuote($quote);

    if ($quote->getIsVirtual()) {
        $quote->setBillingAddress($addressInformation->getAddress());
    } else {
        $quote->setShippingAddress($addressInformation->getAddress());
        $quote->getShippingAddress()->setCollectShippingRates(true)->setShippingMethod(
            $addressInformation->getShippingCarrierCode() . '_' . $addressInformation->getShippingMethodCode()
        );
    }
    $quote->collectTotals();

    return $this->cartTotalRepository->get($cartId);
}

I'm not sure if this is intentional or what the logic is behind this, but the last 2 lines should be re-evaluated, to consider the following:

This is the only place where I find totals collection without a wrapping call to save by the repository
The quote is presumably reloaded by the repository on the return statement

I was able to solve my issue in a way different from @flancer64 by changing the totals collection call like so:

    $this->cartRepository->save($quote->collectTotals());

Alternatively you could return the prepared quote itself instead of reloading from the repository, but I'm unsure of the intention/design of this method to commit a save back on the record. I'd like to hear some thoughts from those more familiar with the architecture here.

andrewhowdencom · 2018-03-14T16:05:21Z

Still present in 2.3. #12993

winterk80 · 2018-05-04T00:53:33Z

Also experiencing this in 2.2.3

lano-vargas · 2018-05-15T13:39:31Z

I am having this issue on checkout when user has an account for the first time then log out add to cart then at checkout enter email and password hit login I get exactly as described PHP Fatal error: Uncaught TypeError: Argument 1 passed to Magento\Quote\Model\Cart\Totals::setExtensionAttributes() ....
instance of Magento\Quote\Api\Data\AddressExtension given ....

Is there a quick fix?

vbuck · 2018-05-16T14:22:30Z

@lano-vargas have you tried my suggested fix on the core?

#12655 (comment)

It would be the "quick fix." Short of that, you can do something as an extension, via plugins:

Register plugin on webapi_rest/di.xml for \Magento\Checkout\Model\TotalsInformationManagement
Implement plugin with method aroundCalculate
Change behavior as I prescribed, such that you save the quote before returning it

popatkaran · 2018-05-19T05:37:34Z

Working on #dmcdindia

magento-engcom-team · 2018-05-19T05:37:37Z

@popatkaran thank you for joining. Please accept team invitation here and self-assign the issue.

0franco · 2018-07-06T16:51:32Z

Same issue v. 2.2.2, fixed with your module @flancer64 thank you!

SolRey · 2018-07-16T07:57:07Z

Thanks @flancer64 , Yous module fixed my issue in 2.2.3 :)

RyanZolper · 2018-08-28T18:41:02Z

I have tested this on various versions, including 2.2.3 and 2.3-develop, and confirmed that this issue has been fixed. Below are the relevant pull requests:

Original fix in 2.1-develop (aa535e)
Forwardport to 2.2-develop (https://github.com/magento/magento2ce/pull/1975/files)
Forwardport to 2.3-develop (https://github.com/magento/magento2/pull/17620/files)

CC @okorshenko

okorshenko · 2018-08-28T18:56:20Z

Hi @RyanZolper Thank you for the research! 👍

qrider · 2018-10-23T13:12:20Z

Is this fixed in the latest versions? > 2.2.4? Just wondering if I would need to reapply the patch.

fwolfst changed the title ~~Checkout/Cart shows error after update 2.2.1 -> 2.2.2~~ Checkout/Cart visit results in error (500) after update 2.2.1 -> 2.2.2 Dec 12, 2017

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 12, 2017

magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Feb 16, 2018

vbuck mentioned this issue Mar 14, 2018

Type error in Cart/Totals #12993

Closed

magento-engcom-team added the Event: distributed-cd Distributed Contribution Day label Mar 19, 2018

magento deleted a comment from magento-engcom-team Mar 23, 2018

magento deleted a comment from tolyantrain Mar 23, 2018

magento deleted a comment from magento-engcom-team Mar 23, 2018

magento-engcom-team added Award: advanced and removed Event: distributed-cd Distributed Contribution Day labels Apr 13, 2018

vrann added the Imagine2018 label Apr 13, 2018

magento-engcom-team added the Event: dmcdindia label May 19, 2018

popatkaran assigned popatkaran and unassigned popatkaran May 19, 2018

magento-engcom-team removed Award: advanced Imagine2018 Event: dmcdindia labels May 26, 2018

RyanZolper closed this as completed Aug 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checkout/Cart visit results in error (500) after update 2.2.1 -> 2.2.2 #12655

Checkout/Cart visit results in error (500) after update 2.2.1 -> 2.2.2 #12655

fwolfst commented Dec 12, 2017

fwolfst commented Dec 12, 2017 •

edited

Loading

webazad commented Dec 15, 2017

darinda commented Dec 15, 2017

wilzon008 commented Dec 15, 2017

friimaind commented Dec 21, 2017 •

edited

Loading

twa8000 commented Dec 23, 2017

cmuench commented Dec 29, 2017

mombrea commented Dec 29, 2017 •

edited

Loading

JonnyStecchino commented Jan 2, 2018

bydrei commented Jan 4, 2018 •

edited

Loading

fwolfst commented Jan 6, 2018

keywoker commented Jan 11, 2018

artklassen commented Jan 22, 2018

OwenMelbz commented Feb 6, 2018

flancer64 commented Feb 16, 2018

magento-engcom-team commented Feb 16, 2018

Sil-B commented Feb 22, 2018 •

edited

Loading

njbair commented Feb 22, 2018

al1357 commented Mar 8, 2018 •

edited

Loading

fluential commented Mar 8, 2018

vbuck commented Mar 9, 2018 •

edited

Loading

andrewhowdencom commented Mar 14, 2018

winterk80 commented May 4, 2018

lano-vargas commented May 15, 2018

vbuck commented May 16, 2018

popatkaran commented May 19, 2018

magento-engcom-team commented May 19, 2018

0franco commented Jul 6, 2018

SolRey commented Jul 16, 2018

RyanZolper commented Aug 28, 2018

okorshenko commented Aug 28, 2018

qrider commented Oct 23, 2018

Checkout/Cart visit results in error (500) after update 2.2.1 -> 2.2.2 #12655

Checkout/Cart visit results in error (500) after update 2.2.1 -> 2.2.2 #12655

Comments

fwolfst commented Dec 12, 2017

Preconditions

Steps to reproduce

Expected result

Actual result

fwolfst commented Dec 12, 2017 • edited Loading

webazad commented Dec 15, 2017

darinda commented Dec 15, 2017

wilzon008 commented Dec 15, 2017

friimaind commented Dec 21, 2017 • edited Loading

twa8000 commented Dec 23, 2017

cmuench commented Dec 29, 2017

mombrea commented Dec 29, 2017 • edited Loading

JonnyStecchino commented Jan 2, 2018

bydrei commented Jan 4, 2018 • edited Loading

fwolfst commented Jan 6, 2018

keywoker commented Jan 11, 2018

artklassen commented Jan 22, 2018

OwenMelbz commented Feb 6, 2018

flancer64 commented Feb 16, 2018

magento-engcom-team commented Feb 16, 2018

Sil-B commented Feb 22, 2018 • edited Loading

njbair commented Feb 22, 2018

al1357 commented Mar 8, 2018 • edited Loading

fluential commented Mar 8, 2018

vbuck commented Mar 9, 2018 • edited Loading

andrewhowdencom commented Mar 14, 2018

winterk80 commented May 4, 2018

lano-vargas commented May 15, 2018

vbuck commented May 16, 2018

popatkaran commented May 19, 2018

magento-engcom-team commented May 19, 2018

0franco commented Jul 6, 2018

SolRey commented Jul 16, 2018

RyanZolper commented Aug 28, 2018

okorshenko commented Aug 28, 2018

qrider commented Oct 23, 2018

fwolfst commented Dec 12, 2017 •

edited

Loading

friimaind commented Dec 21, 2017 •

edited

Loading

mombrea commented Dec 29, 2017 •

edited

Loading

bydrei commented Jan 4, 2018 •

edited

Loading

Sil-B commented Feb 22, 2018 •

edited

Loading

al1357 commented Mar 8, 2018 •

edited

Loading

vbuck commented Mar 9, 2018 •

edited

Loading