Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to a member function addCrumb() #11275

Closed
lano-vargas opened this issue Oct 6, 2017 · 11 comments
Closed

Call to a member function addCrumb() #11275

lano-vargas opened this issue Oct 6, 2017 · 11 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@lano-vargas
Copy link

lano-vargas commented Oct 6, 2017

I have encounter a small issue on new installation of Magento 2.1.7 regards to breadcrumbs.

step to recreate the issue is simple once install is susccesfull:

1- create custom Theme
2- create default.xml
3- add <referenceBlock name="breadcrumbs" remove="true" />
4- navigate to your Magento installation root url .../sales/guest/form/

5- error: 500

Log:
PHP Fatal error: Call to a member function addCrumb() on boolean in /Library/WebServer/Documents/dev/vendor/magento/module-sales/Helper/Guest.php on line 205

Comment or removing

/($breadcrumbs->addCrumb(
'home',
[
'label' => __('Home'),
'title' => __('Go to Home Page'),
'link' => $this->_storeManager->getStore()->getBaseUrl()
]
);
$breadcrumbs->addCrumb(
'cms_page',
['label' => __('Order Information'), 'title' => __('Order Information')]
);
/

Will display the the page correctly.

Thank's
Juliano

@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed SQUASHTOBERFEST Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

Hi @lano-vargas
thank you for the report. Would like submit a pull request with the fix? By this, you can participate in #SQUASHTOBERFEST

@magento-engcom-team
Copy link
Contributor

The fix looks simple

@lano-vargas
Copy link
Author

lano-vargas commented Oct 6, 2017

@magento-engcom-team I can't promise but will try and work on it this weekend.

I'm working on it #SQUASHTOBERFEST.

Thanks.

lano-vargas added a commit to lano-vargas/magento2 that referenced this issue Oct 8, 2017
@lano-vargas lano-vargas mentioned this issue Oct 8, 2017
4 tasks
@lano-vargas
Copy link
Author

@magento-engcom-team the "continuous-integration/travis-ci/pr" has errored with

"The job exceeded the maximum time limit for jobs, and has been terminated."

ref: https://travis-ci.org/magento/magento2/jobs/285215690

Please advice what to do next.
Thanks.

@lano-vargas
Copy link
Author

@okorshenko Could you please restart build/trigger as mentioned here:https://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit
Appreciate.

@orlangur
Copy link
Contributor

@lano-vargas restarted, main CI source of truth is Bamboo runned internally, I'll let you know if there will be some issues revealed.

@lano-vargas
Copy link
Author

lano-vargas commented Oct 11, 2017

@magento-engcom-team errored for the same reason as #11275 (comment)

@lano-vargas lano-vargas mentioned this issue Oct 11, 2017
4 tasks
@adrian-martinez-interactiv4
Copy link
Contributor

@magento-engcom-team This issue should be closed, solved in PR #11382

@okorshenko
Copy link
Contributor

the issue has been fixed and delivered to 2.2.2 branch. Will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 18, 2017
@magento-team magento-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 18, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81647

@magento-engcom-team
Copy link
Contributor

Hi @lano-vargas. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1283 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

6 participants