Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect use of implode() #1116

Closed
michsk opened this issue Mar 21, 2015 · 3 comments
Closed

Incorrect use of implode() #1116

michsk opened this issue Mar 21, 2015 · 3 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@michsk
Copy link

michsk commented Mar 21, 2015

In magento2/app/code/Magento/Tax/Setup/InstallData.php on line 76 there is a wrong use of implode()

'apply_to' => implode($taxSetup->getTaxableItems(), ',')

it should be $glue, $pieces.
@kandy
Copy link
Contributor

kandy commented Mar 21, 2015

implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.
http://php.net/manual/en/function.implode.php

But, I agree that better to use it in common way

@vpelipenko vpelipenko added CS bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Mar 23, 2015
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-35411

@RMcLeod79 RMcLeod79 mentioned this issue Mar 25, 2015
Merged
vpelipenko added a commit that referenced this issue Mar 27, 2015
@vpelipenko
MAGETWO-35411: [GITHUB] Incorrect use of implode() #1116
21f1ebd
@vpelipenko
Copy link
Contributor

@michal-sk, fix for this issue is available in public repository after recent update. Please, check it.

@michsk michsk closed this as completed Mar 28, 2015
ericthehacker pushed a commit to ericthehacker/magento2 that referenced this issue Mar 29, 2015
Merge branch 'develop' into feature/native-password-hashing
2933797 
* develop: (3965 commits)
  MAGETWO-31777: M2 GitHub Update (version 0.74.0-beta2)
  MAGETWO-31777: M2 GitHub Update (version 0.74.0-beta2)
  MAGETWO-35405: Magento\Multishipping\Controller\CheckoutTest::testOverviewAction is falied on Travis CI
  MAGETWO-35405: Magento\Multishipping\Controller\CheckoutTest::testOverviewAction is falied on Travis CI
  Change wording for long operation warning
  Fixed occurances of implode with wrong argument order
  MAGETWO-31086: M2 GitHub Update (version 0.74.0-beta1)
  MAGETWO-35411: [GITHUB] Incorrect use of implode() magento#1116
  MAGETWO-35182: The link of "URL" type breaks "edit Downloadable" Backend page
  MAGETWO-31086: M2 GitHub Update (version 0.74.0-beta1)
  MAGETWO-18366: CLONE - Wrong capitalization of label names (sentence-style capitalization instead headline style) + Inconsistency in labels in the Admin Panel
  MAGETWO-35392: [GitHub] Google Analytics Script Minify problem magento#1114
  MAGETWO-35385:  Fatal error when trying to send notify customer by email about shipment
  MAGETWO-35385:  Fatal error when trying to send notify customer by email about shipment
  MAGETWO-35385:  Fatal error when trying to send notify customer by email about shipment
  MAGETWO-35385:  Fatal error when trying to send notify customer by email about shipment
  MAGETWO-35385:  Fatal error when trying to send notify customer by email about shipment
  MAGETWO-35385:  Fatal error when trying to send notify customer by email about shipment
  MAGETWO-35043: Tabs widget does not initialize sometimes on Product Creation page
  MAGETWO-35386: Blank email is sent when trying to change password for a customer
  ...

Conflicts:
	dev/tests/unit/testsuite/Magento/Framework/Encryption/EncryptorTest.php
magento-team added a commit to abeeskau/magento2-community-edition that referenced this issue Mar 31, 2015
@magento-team
0.74.0-beta2
45f64a1 
* Fixed bugs
    * Wrong capitalization of the label names (the sentence-style capitalization instead of the headline style)
    * Inconsistency in the labels in the Admin panel
    * Customer menu tabs aren't displayed as selected for the child pages
    * An issue with the Active item in the navigation menu in the Blank and Luma themes
    * Incorrect price alignment during checkout in the Blank and Luma themes
    * Broken field "URL" in the Downloadable product in the Admin panel
* GitHub issues and requests:
    * [#1096] (magento/magento2#1096) -- Customer model - getPrimaryAddresses without primary billing address
    * [#1114] (magento/magento2#1114) -- GA bug
    * [#1116] (magento/magento2#1116) -- Incorrect use of implode()
    * [#1126] (magento/magento2#1126) -- Fixed occurrences of implode with wrong argument order
    * [#1128] (magento/magento2#1128) -- Change wording for long operation warning
magento-team added a commit to abeeskau/magento2-community-edition that referenced this issue Apr 8, 2015
@magento-team
0.74.0-beta2
15bf44f 
* Fixed bugs
    * Wrong capitalization of the label names (the sentence-style capitalization instead of the headline style)
    * Inconsistency in the labels in the Admin panel
    * Customer menu tabs aren't displayed as selected for the child pages
    * An issue with the Active item in the navigation menu in the Blank and Luma themes
    * Incorrect price alignment during checkout in the Blank and Luma themes
    * Broken field "URL" in the Downloadable product in the Admin panel
* GitHub issues and requests:
    * [#1096] (magento/magento2#1096) -- Customer model - getPrimaryAddresses without primary billing address
    * [#1114] (magento/magento2#1114) -- GA bug
    * [#1116] (magento/magento2#1116) -- Incorrect use of implode()
    * [#1126] (magento/magento2#1126) -- Fixed occurrences of implode with wrong argument order
    * [#1128] (magento/magento2#1128) -- Change wording for long operation warning
okorshenko pushed a commit that referenced this issue Jul 5, 2017
Merge pull request #1116 from magento-tsg/2.1.8-develop-pr11
ff253a7 
[TSG] Backporting for 2.1 (pr11) (2.1.8)
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
magento#1116 Refactored modularity of the InventoryAdminUi module
4a2051d
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
magento#1116 Cleaned up dependencies in composer.json
9609472
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
@maghamed
Merge pull request magento#1121 from magento-engcom/1116-InventoryAdm…
77960ad 
…inUi-modularity

magento#1116 Resolve dependency InventoryAdminUi on Inventory module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kandy @michsk @vpelipenko