Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug generating Sitemap Cron expression #1020

Closed
barbazul opened this issue Feb 4, 2015 · 2 comments
Closed

Bug generating Sitemap Cron expression #1020

barbazul opened this issue Feb 4, 2015 · 2 comments
Labels
bug report

Comments

@barbazul
Copy link
Contributor

barbazul commented Feb 4, 2015

I just found this in M1, surprised to see it is also in M2.

app/code/Magento/Cron/Model/Config/Backend/Sitemap.php line 68 reads

$frequency = $this->getData('groups/generate/frequency/value');

And should read

$frequency = $this->getData('groups/generate/fields/frequency/value');

This causes $frequency to be always false and so, sitemap is always generated daily regardless of configuration

Edit: Typo
@otoolec
Copy link
Contributor

otoolec commented Feb 4, 2015

Thanks for submitting this bug, the internal ticket is MAGETWO-33637

@sshrewz sshrewz added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 5, 2015
@sshrewz sshrewz removed the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 3, 2015
magento-team pushed a commit that referenced this issue Mar 23, 2015
MAGETWO-33637: [GITHUB] Bug generating Sitemap Cron expression #1020
752bacc 
- These are rebased commits.
magento-team pushed a commit that referenced this issue Mar 23, 2015
MAGETWO-33637: [GITHUB] Bug generating Sitemap Cron expression #1020
a299b83 
- Code style fixes.
@sshrewz
Copy link

sshrewz commented Mar 23, 2015

@barbazul, this has been fixed in 0.74.0-beta1. Thank you again for submitting this issue. Should you have any other issues, please don't hesitate to contact us.

@sshrewz sshrewz closed this as completed Mar 23, 2015
magento-team pushed a commit that referenced this issue Apr 12, 2017
Merge pull request #1020 from magento-engcom/develop-prs
e9d894f 
Public Pull Requests:

#9140
#9204
#9133
#6778
#7556
#8903
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
@maghamed
Merge pull request magento#1020 from magento-engcom/723
93a93f6 
MSI-723: Implement IsCorrectQtyConditionTest::testExecuteWithMaxSaleQty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@barbazul @otoolec @vpelipenko @sshrewz