Skip to content

Commit

Permalink
Implement catching for all Errors - ref Magento issue #23350
Browse files Browse the repository at this point in the history
  • Loading branch information
accmiszyman committed Oct 23, 2019
1 parent 7ad8863 commit ee8373f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/internal/Magento/Framework/App/Bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ public function run(AppInterface $application)
}
} catch (\Exception $e) {
$this->terminate($e);
} catch (\Error $e) {
$this->terminate($e);
}
} // phpcs:enable

Expand Down Expand Up @@ -418,12 +420,12 @@ public function isDeveloperMode()
/**
* Display an exception and terminate program execution
*
* @param \Exception $e
* @param \Throwable $e
* @return void
*
* phpcs:disable Magento2.Security.LanguageConstruct, Squiz.Commenting.FunctionCommentThrowTag
*/
protected function terminate(\Exception $e)
protected function terminate(\Throwable $e)
{

if ($this->isDeveloperMode()) {
Expand Down

0 comments on commit ee8373f

Please sign in to comment.