Skip to content

Commit

Permalink
Fixes two issues; the type error surfaced by use of strict_types in 2…
Browse files Browse the repository at this point in the history
….3-develop and issue where SCD hangs ending in RuntimeException on 2.2-develop

Resolves #22563 and #21852
  • Loading branch information
davidalger committed May 2, 2019
1 parent 7631cbc commit e1525a8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions app/code/Magento/Deploy/Process/Queue.php
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ private function isDeployed(Package $package)
{
if ($this->isCanBeParalleled()) {
if ($package->getState() === null) {
$pid = $this->getPid($package);
if ($pid === null) {
return false;
}

// phpcs:ignore Magento2.Functions.DiscouragedFunction
$result = pcntl_waitpid($pid, $status, WNOHANG);
if ($result === $pid) {
Expand Down

0 comments on commit e1525a8

Please sign in to comment.