MAGETWO-91620: It is not possible to use function setInAllAttributeSe…

…tsFilter() together with getAllIds() for class Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection - Modified having clause to use aggregation function instead of alias
magento · Aug 8, 2018 · d93e5c7 · d93e5c7
1 parent 0e2bca6
commit d93e5c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Collection.php
@@ -222,7 +222,7 @@ public function setInAllAttributeSetsFilter(array $setIds)
                     $setIds
                 )
                 ->group('entity_attribute.attribute_id')
-                ->having('count = ' . count($setIds));
+                ->having(new \Zend_Db_Expr('COUNT(*)') . ' = ' . count($setIds));
         }
 
         //$this->getSelect()->distinct(true);

diff --git a/app/code/Magento/Eav/Test/Unit/Model/ResourceModel/Entity/Attribute/CollectionTest.php b/app/code/Magento/Eav/Test/Unit/Model/ResourceModel/Entity/Attribute/CollectionTest.php
@@ -150,7 +150,7 @@ public function testSetInAllAttributeSetsFilter()
         $this->selectMock->expects($this->atLeastOnce())->method('group')->with('entity_attribute.attribute_id')
             ->willReturnSelf();
 
-        $this->selectMock->expects($this->atLeastOnce())->method('having')->with('count = ' . count($setIds))
+        $this->selectMock->expects($this->atLeastOnce())->method('having')->with(new \Zend_Db_Expr('COUNT(*)') . ' = ' . count($setIds))
             ->willReturnSelf();
 
         $this->model->setInAllAttributeSetsFilter($setIds);