apply code review recommendations

magento · Apr 11, 2020 · c412681 · c412681
1 parent fc1a6c5
commit c412681
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 33 deletions.
diff --git a/...code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontOpenCheckoutCartPageActionGroup.xml b/...code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontOpenCheckoutCartPageActionGroup.xml
diff --git a/...ckout/Test/Mftf/Test/StorefrontVisiblePasswordFieldForUnregisteredEmailOnCheckoutTest.xml b/...ckout/Test/Mftf/Test/StorefrontVisiblePasswordFieldForUnregisteredEmailOnCheckoutTest.xml
@@ -14,36 +14,27 @@
             <stories value="Visible password field for unregistered e-mail on Checkout"/>
             <title value="Visibility password field for unregistered e-mail on Checkout process"/>
             <description value="Guest should not be able to see password field if entered unregistered email"/>
-            <stories value="Guest Checkout"/>
-            <testCaseId value="MC-14695"/>
-            <severity value="CRITICAL"/>
+            <severity value="MINOR"/>
             <group value="checkout"/>
-            <group value="shoppingCart"/>
-            <group value="mtf_migrated"/>
         </annotations>
         <before>
             <createData entity="SimpleTwo" stepKey="simpleProduct"/>
         </before>
-
         <after>
             <deleteData createDataKey="simpleProduct" stepKey="deleteProduct"/>
         </after>
-
         <actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openProductStorefront">
             <argument name="productUrl" value="$$simpleProduct.custom_attributes[url_key]$$"/>
         </actionGroup>
         <actionGroup ref="StorefrontClickAddToCartOnProductPageActionGroup" stepKey="addToCartFromStorefrontProductPage"/>
-
         <actionGroup ref="StorefrontOpenCheckoutPageActionGroup" stepKey="openCheckoutPage"/>
         <actionGroup ref="AssertStorefrontEmailTooltipContentOnCheckoutActionGroup" stepKey="assertEmailTooltipContent"/>
         <actionGroup ref="AssertStorefrontEmailNoteMessageOnCheckoutActionGroup" stepKey="assertEmailNoteMessage"/>
-
         <actionGroup ref="StorefrontFillEmailFieldOnCheckoutActionGroup" stepKey="fillUnregisteredEmailFirstAttempt">
             <argument name="email" value="[email protected]"/>
         </actionGroup>
-        <actionGroup ref="AssertStorefrontVisiblePasswordFieldForUnregisteredEmailOnCheckoutActionGroup"
-                     stepKey="checkIfPasswordVisibleAfterFieldFilling"/>
-        <actionGroup ref="StorefrontOpenCheckoutCartPageActionGroup" stepKey="openCheckoutCartPage" />
+        <actionGroup ref="AssertStorefrontVisiblePasswordFieldForUnregisteredEmailOnCheckoutActionGroup" stepKey="checkIfPasswordVisibleAfterFieldFilling"/>
+        <actionGroup ref="StorefrontOpenCheckoutPageActionGroup" stepKey="reloadCheckoutPage" />
         <actionGroup ref="AssertStorefrontVisiblePasswordFieldForUnregisteredEmailOnCheckoutActionGroup"
                      stepKey="checkIfPasswordVisibleAfterPageReload"/>
     </test>