magento-engcom/import-export-improvements#30: Refactoring for readabi…

…lity.
magento · Jul 6, 2018 · b4ce314 · b4ce314
1 parent 0832e29
commit b4ce314
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/app/code/Magento/CustomerImportExport/Model/Import/Customer.php b/app/code/Magento/CustomerImportExport/Model/Import/Customer.php
@@ -593,12 +593,18 @@ protected function _validateRowForUpdate(array $rowData, $rowNumber)
                 if (in_array($attributeCode, $this->_ignoredAttributes)) {
                     continue;
                 }
-                if ($attributeParams['is_required']
-                    && ((!isset($rowData[$attributeCode]) && !$this->_getCustomerId($email, $website))
-                    || (isset($rowData[$attributeCode]) && '' === trim($rowData[$attributeCode])))) {
+
+                $isFieldRequired = $attributeParams['is_required'];
+                $isFieldNotSetAndCustomerDoesNotExist =
+                    !isset($rowData[$attributeCode]) && !$this->_getCustomerId($email, $website);
+                $isFieldSetAndTrimmedValueIsEmpty
+                    = isset($rowData[$attributeCode]) && '' === trim($rowData[$attributeCode]);
+
+                if ($isFieldRequired && ($isFieldNotSetAndCustomerDoesNotExist || $isFieldSetAndTrimmedValueIsEmpty)) {
                     $this->addRowError(self::ERROR_VALUE_IS_REQUIRED, $rowNumber, $attributeCode);
                     continue;
                 }
+
                 if (isset($rowData[$attributeCode]) && strlen($rowData[$attributeCode])) {
                     $this->isAttributeValid(
                         $attributeCode,