Skip to content

Commit

Permalink
2.0.0.0-dev82
Browse files Browse the repository at this point in the history
* Added support for MTF Reporting Tool
* Framework improvements:
  * Covered the following Magento application components with unit tests:
      * `ConfigurableProduct/Helper/Data.php`
      * `ConfigurableProduct/Model/Export/RowCustomizer.php`
      * `ConfigurableProduct/Model/Product/Type/Configurable.php`
      * `ConfigurableProduct/Model/Product/Type/Plugin.php`
      * `ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php`
      * `CatalogSearch/Helper/Data.php`
  * Covered Magento lib with unit tests:
      * `lib/internal/Magento/Framework/DB/Helper/AbstractHelper.php`
      * `lib/internal/Magento/Framework/DB/Tree/Node.php`
* Created Service API for Magento_Catalog Module:
  * Implemented the Product API
  * Implemented the ProductAttributeRead API
* Fixed bugs:
  * Fixed issues with form elements visibility on the backend
  * Fixed an issue where backend forms contained an excessive container
  * Fixed an issue where a wrong category structure was displayed on the Category page
  * Fixed an issue where the pub/index.php entry point was broken because of the obsolete constants
  * Fixed an issue where it was impossible to pass an empty array as an argument in DI configuration and layout updates
  * Fixed an issue with status and visibility settings of a related product on the backend
  * Fixed an issue with unused DB indexes, which used resources, but did not contribute to higher performance
  * Fixed an issue where it was possible to create a downloadable product without specifying a link or a file
  * Fixed an issue where a fatal error occured when opening a fixed bundle product with custom options page on the frontend
  * Fixed an issue where the was a wrong config key for backend cataloginventory
* Processed GitHub requests:
  * [#548] (#548) -- Console installer doesn't checks filesystem permissions
  * [#552] (#552) -- backend notifications sitebuild bug
  * [#562] (#562) -- Bugfix Magento\Framework\DB\Adapter\Pdo\Mysql::getCreateTable()
  * [#565] (#565) -- Magento\CatalogSearch\Model\Query::getResultCollection() not working
  * [#557] (#557) -- translation anomalies backend login page
* Added the following functional tests:
  * Advanced Search
  * Existing Customer Creation
  * Product Attribute Creation
  * Product Rating Creation
  * Sales Rule Creation
  * System Product Attribute Deletion
  * Tax Rate Creation
  * Tax Rule Deletion
  * Update Category
  * Update Category Url Rewrite
  * Update Product Url Rewrite
  • Loading branch information
magento-team committed Jun 16, 2014
1 parent d895f13 commit 658b76f
Show file tree
Hide file tree
Showing 413 changed files with 19,087 additions and 8,256 deletions.
47 changes: 47 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,50 @@
2.0.0.0-dev82
=============
* Added support for MTF Reporting Tool
* Framework improvements:
* Covered the following Magento application components with unit tests:
* `ConfigurableProduct/Helper/Data.php`
* `ConfigurableProduct/Model/Export/RowCustomizer.php`
* `ConfigurableProduct/Model/Product/Type/Configurable.php`
* `ConfigurableProduct/Model/Product/Type/Plugin.php`
* `ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php`
* `CatalogSearch/Helper/Data.php`
* Covered Magento lib with unit tests:
* `lib/internal/Magento/Framework/DB/Helper/AbstractHelper.php`
* `lib/internal/Magento/Framework/DB/Tree/Node.php`
* Created Service API for Magento_Catalog Module:
* Implemented the Product API
* Implemented the ProductAttributeRead API
* Fixed bugs:
* Fixed issues with form elements visibility on the backend
* Fixed an issue where backend forms contained an excessive container
* Fixed an issue where a wrong category structure was displayed on the Category page
* Fixed an issue where the pub/index.php entry point was broken because of the obsolete constants
* Fixed an issue where it was impossible to pass an empty array as an argument in DI configuration and layout updates
* Fixed an issue with status and visibility settings of a related product on the backend
* Fixed an issue with unused DB indexes, which used resources, but did not contribute to higher performance
* Fixed an issue where it was possible to create a downloadable product without specifying a link or a file
* Fixed an issue where a fatal error occured when opening a fixed bundle product with custom options page on the frontend
* Fixed an issue where the was a wrong config key for backend cataloginventory
* Processed GitHub requests:
* [#548] (https://github.com/magento/magento2/issues/548) -- Console installer doesn't checks filesystem permissions
* [#552] (https://github.com/magento/magento2/issues/552) -- backend notifications sitebuild bug
* [#562] (https://github.com/magento/magento2/pull/562) -- Bugfix Magento\Framework\DB\Adapter\Pdo\Mysql::getCreateTable()
* [#565] (https://github.com/magento/magento2/pull/565) -- Magento\CatalogSearch\Model\Query::getResultCollection() not working
* [#557] (https://github.com/magento/magento2/issues/557) -- translation anomalies backend login page
* Added the following functional tests:
* Advanced Search
* Existing Customer Creation
* Product Attribute Creation
* Product Rating Creation
* Sales Rule Creation
* System Product Attribute Deletion
* Tax Rate Creation
* Tax Rule Deletion
* Update Category
* Update Category Url Rewrite
* Update Product Url Rewrite

2.0.0.0-dev81
=============
* Framework improvements:
Expand Down
7 changes: 6 additions & 1 deletion app/code/Magento/AdminNotification/Block/ToolbarEntry.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
*/
class ToolbarEntry extends \Magento\Backend\Block\Template
{
/**
* Number of notifications showed on expandable window
*/
const NOTIFICATIONS_NUMBER = 4;

/**
* Collection of latest unread notifications
*
Expand Down Expand Up @@ -68,7 +73,7 @@ public function getUnreadNotificationCount()
*/
public function getLatestUnreadNotifications()
{
return $this->_notificationList;
return $this->_notificationList->setPageSize(self::NOTIFICATIONS_NUMBER);
}

/**
Expand Down
69 changes: 32 additions & 37 deletions app/code/Magento/Backend/Block/Widget/Grid/Extended.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Ba
*
* @var \Magento\Framework\Data\Collection
*/
protected $_collection = null;
protected $_collection;

/**
* Export flag
Expand Down Expand Up @@ -81,14 +81,14 @@ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Ba
*
* @var string
*/
protected $_massactionIdField = null;
protected $_massactionIdField;

/**
* Massaction row id filter
*
* @var string
*/
protected $_massactionIdFilter = null;
protected $_massactionIdFilter;

/**
* Massaction block name
Expand Down Expand Up @@ -202,9 +202,7 @@ protected function _prepareLayout()
{
$this->setChild(
'export_button',
$this->getLayout()->createBlock(
'Magento\Backend\Block\Widget\Button'
)->setData(
$this->getLayout()->createBlock('Magento\Backend\Block\Widget\Button')->setData(
array(
'label' => __('Export'),
'onclick' => $this->getJsObjectName() . '.doExport()',
Expand All @@ -214,17 +212,13 @@ protected function _prepareLayout()
);
$this->setChild(
'reset_filter_button',
$this->getLayout()->createBlock(
'Magento\Backend\Block\Widget\Button'
)->setData(
$this->getLayout()->createBlock('Magento\Backend\Block\Widget\Button')->setData(
array('label' => __('Reset Filter'), 'onclick' => $this->getJsObjectName() . '.resetFilter()')
)
);
$this->setChild(
'search_button',
$this->getLayout()->createBlock(
'Magento\Backend\Block\Widget\Button'
)->setData(
$this->getLayout()->createBlock('Magento\Backend\Block\Widget\Button')->setData(
array(
'label' => __('Search'),
'onclick' => $this->getJsObjectName() . '.doFilter()',
Expand Down Expand Up @@ -289,15 +283,11 @@ public function addColumn($columnId, $column)
if (is_array($column)) {
$this->getColumnSet()->setChild(
$columnId,
$this->getLayout()->createBlock(
'Magento\Backend\Block\Widget\Grid\Column\Extended'
)->setData(
$column
)->setId(
$columnId
)->setGrid(
$this
)
$this->getLayout()
->createBlock('Magento\Backend\Block\Widget\Grid\Column\Extended')
->setData($column)
->setId($columnId)
->setGrid($this)
);
$this->getColumnSet()->getChildBlock($columnId)->setGrid($this);
} else {
Expand Down Expand Up @@ -437,19 +427,19 @@ protected function _prepareMassaction()
protected function _prepareMassactionColumn()
{
$columnId = 'massaction';
$massactionColumn = $this->getLayout()->createBlock(
'Magento\Backend\Block\Widget\Grid\Column'
)->setData(
array(
'index' => $this->getMassactionIdField(),
'filter_index' => $this->getMassactionIdFilter(),
'type' => 'massaction',
'name' => $this->getMassactionBlock()->getFormFieldName(),
'is_system' => true,
'header_css_class' => 'col-select',
'column_css_class' => 'col-select'
)
);
$massactionColumn = $this->getLayout()
->createBlock('Magento\Backend\Block\Widget\Grid\Column')
->setData(
array(
'index' => $this->getMassactionIdField(),
'filter_index' => $this->getMassactionIdFilter(),
'type' => 'massaction',
'name' => $this->getMassactionBlock()->getFormFieldName(),
'is_system' => true,
'header_css_class' => 'col-select',
'column_css_class' => 'col-select'
)
);

if ($this->getNoFilterMassactionColumn()) {
$massactionColumn->setData('filter', false);
Expand Down Expand Up @@ -980,8 +970,10 @@ public function _exportIterateCollection($callback, array $args)
* @param \Magento\Framework\Filesystem\File\WriteInterface $stream
* @return void
*/
protected function _exportCsvItem(\Magento\Framework\Object $item, \Magento\Framework\Filesystem\File\WriteInterface $stream)
{
protected function _exportCsvItem(
\Magento\Framework\Object $item,
\Magento\Framework\Filesystem\File\WriteInterface $stream
) {
$row = array();
foreach ($this->getColumns() as $column) {
if (!$column->getIsSystem()) {
Expand Down Expand Up @@ -1142,7 +1134,10 @@ public function getExcelFile($sheetName = '')
$this->_isExport = true;
$this->_prepareGrid();

$convert = new \Magento\Framework\Convert\Excel($this->getCollection()->getIterator(), array($this, 'getRowRecord'));
$convert = new \Magento\Framework\Convert\Excel(
$this->getCollection()->getIterator(),
array($this, 'getRowRecord')
);

$name = md5(microtime());
$file = $this->_path . '/' . $name . '.xml';
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/view/adminhtml/layout/default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
</block>
<block class="Magento\Theme\Block\Html\Head\Script" name="jquery-jquery-ui-timepicker-addon-js">
<arguments>
<argument name="file" xsi:type="string">jquery/jquery-ui-timepicker-addon-1.0.1.js</argument>
<argument name="file" xsi:type="string">jquery/jquery-ui-timepicker-addon.js</argument>
</arguments>
</block>
<block class="Magento\Theme\Block\Html\Head\Script" name="magento-calendar-js">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@
<div class="field field-username">
<label for="username" class="label"><span><?php echo __('User Name:') ?></span></label>
<div class="control">
<input type="text" id="username" name="login[username]" value="" class="required-entry input-text" placeholder="user name" />
<input type="text" id="username" name="login[username]" value="" class="required-entry input-text" placeholder="<?php echo __('user name') ?>" />
</div>
</div>
<div class="field field-password">
<label for="login" class="label"><?php echo __('Password:') ?></label>
<div class="control">
<!-- This is a dummy hidden field to trick firefox from auto filling the password -->
<input type="text" class="input-text no-display" name="dummy" id="dummy" />
<input type="password" id="login" name="login[password]" class="required-entry input-text" value="" placeholder="password" />
<input type="password" id="login" name="login[password]" class="required-entry input-text" value="" placeholder="<?php echo __('password') ?>" />
</div>
</div>
<?php echo $this->getChildHtml('form.additional.info'); ?>
Expand Down
51 changes: 51 additions & 0 deletions app/code/Magento/Bundle/Model/Plugin/PriceBackend.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<?php
/**
* Magento
*
* NOTICE OF LICENSE
*
* This source file is subject to the Open Software License (OSL 3.0)
* that is bundled with this package in the file LICENSE.txt.
* It is also available through the world-wide-web at this URL:
* http://opensource.org/licenses/osl-3.0.php
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to [email protected] so we can send you a copy immediately.
*
* DISCLAIMER
*
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
*
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Bundle\Model\Plugin;

/**
* Class PriceBackend
*
* Make price validation optional for bundle dynamic
*/
class PriceBackend
{
/**
* @param \Magento\Catalog\Model\Product\Attribute\Backend\Price $subject
* @param Closure $proceed
* @param \Magento\Catalog\Model\Product $product
* @return bool
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function aroundValidate(
\Magento\Catalog\Model\Product\Attribute\Backend\Price $subject,
\Closure $proceed,
\Magento\Catalog\Model\Product $product
) {
if ($product->getPriceType() == \Magento\Bundle\Model\Product\Price::PRICE_TYPE_DYNAMIC) {
return true;
} else {
return $proceed($product);
}
}
}
3 changes: 3 additions & 0 deletions app/code/Magento/Bundle/etc/adminhtml/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,7 @@
</argument>
</arguments>
</type>
<type name="Magento\Catalog\Model\Product\Attribute\Backend\Price">
<plugin name="bundle" type="Magento\Bundle\Model\Plugin\PriceBackend" sortOrder="100" />
</type>
</config>
1 change: 1 addition & 0 deletions app/code/Magento/Bundle/etc/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
<item name="group_price" xsi:type="string">Magento\Bundle\Pricing\Price\GroupPrice</item>
<item name="special_price" xsi:type="string">Magento\Bundle\Pricing\Price\SpecialPrice</item>
<item name="msrp_price" xsi:type="string">Magento\Catalog\Pricing\Price\MsrpPrice</item>
<item name="custom_option_price" xsi:type="string">Magento\Catalog\Pricing\Price\CustomOptionPrice</item>
<item name="base_price" xsi:type="string">Magento\Catalog\Pricing\Price\BasePrice</item>
<item name="configured_price" xsi:type="string">Magento\Bundle\Pricing\Price\ConfiguredPrice</item>
<item name="bundle_option" xsi:type="string">Magento\Bundle\Pricing\Price\BundleOptionPrice</item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,13 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/

/**
* Products mass update inventory tab
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab;

use Magento\CatalogInventory\Model\Stock\Item;

/**
* Products mass update inventory tab
*/
class Inventory extends \Magento\Backend\Block\Widget implements \Magento\Backend\Block\Widget\Tab\TabInterface
{
/**
Expand Down Expand Up @@ -91,7 +89,11 @@ public function getStoreId()
*/
public function getDefaultConfigValue($field)
{
return $this->_scopeConfig->getValue(Item::XML_PATH_ITEM . $field, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $this->getStoreId());
return $this->_scopeConfig->getValue(
Item::XML_PATH_ITEM . $field,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE,
$this->getStoreId()
);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

/**
* Product inventory data
*
* @author Magento Core Team <[email protected]>
*/
class Inventory extends \Magento\Backend\Block\Widget
{
Expand All @@ -40,14 +38,14 @@ class Inventory extends \Magento\Backend\Block\Widget
*
* @var \Magento\Catalog\Helper\Data
*/
protected $_catalogData = null;
protected $_catalogData;

/**
* Core registry
*
* @var \Magento\Framework\Registry
*/
protected $_coreRegistry = null;
protected $_coreRegistry;

/**
* @var \Magento\CatalogInventory\Model\Source\Stock
Expand Down Expand Up @@ -138,7 +136,10 @@ public function getFieldValue($field)
return $this->getStockItem()->getDataUsingMethod($field);
}

return $this->_scopeConfig->getValue(\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field, \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
return $this->_scopeConfig->getValue(
\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}

/**
Expand All @@ -153,7 +154,10 @@ public function getConfigFieldValue($field)
}
}

return $this->_scopeConfig->getValue(\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field, \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
return $this->_scopeConfig->getValue(
\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}

/**
Expand All @@ -162,7 +166,10 @@ public function getConfigFieldValue($field)
*/
public function getDefaultConfigValue($field)
{
return $this->_scopeConfig->getValue(\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field, \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
return $this->_scopeConfig->getValue(
\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}

/**
Expand Down
Loading

0 comments on commit 658b76f

Please sign in to comment.