Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive - Method has been added #50

Closed
ihor-sviziev opened this issue Sep 16, 2020 · 2 comments
Closed

False positive - Method has been added #50

ihor-sviziev opened this issue Sep 16, 2020 · 2 comments
Labels
Priority: P1 Progress: done Severity: S2

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 16, 2020 •
edited
Loading

We found this issue as part of processing following PR: magento/magento2#30001

When we adding some get parameter and constructor wasn't overridden yet for this class - we're having following failure:
image
image
@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2020

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@ihor-sviziev
Copy link
Contributor Author

Fixed in e64773c

@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
magento-devops-reposync-svc pushed a commit that referenced this issue Nov 17, 2023
@sidolov
Merge pull request #50 from magento-amigos/13.0.0-beta2
3b85c72 
13.0.0-beta2 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P1 Progress: done Severity: S2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ihor-sviziev @okorshenko