Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using PHPUnit_Framework_MockObject_MockObject #178

Closed
lbajsarowicz opened this issue Mar 22, 2020 · 3 comments
Closed

Avoid using PHPUnit_Framework_MockObject_MockObject #178

lbajsarowicz opened this issue Mar 22, 2020 · 3 comments
Labels
accepted New rule is accepted Progress: good first issue Issues is easy to get started with

Comments

@lbajsarowicz
Copy link

Rule

PHPUnit_Framework_MockObject_MockObject triggers warning

Reason

The PHPUnit_Framework_MockObject_MockObject was deprecated long time ago and \PHPUnit\Framework\MockObject\MockObject should be used

Implementation
@lbajsarowicz lbajsarowicz added the proposal New rule proposal label Mar 22, 2020
@lenaorobei lenaorobei added accepted New rule is accepted Progress: good first issue Issues is easy to get started with and removed proposal New rule proposal labels Mar 23, 2020
@ihor-sviziev
Copy link
Collaborator

As for now I added this class to dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php as part of magento/magento2#27519

I don't really think is's good idea to have such check in magento coding standards.

@lenaorobei
Copy link
Contributor

@lbajsarowicz agree with @ihor-sviziev.
I'm closing this issue in favor of internal task MC-33003 for implementing regular static test but not the part of coding standard.

@lbajsarowicz
Copy link
Author

Thank you.

magento-devops-reposync-svc pushed a commit that referenced this issue May 26, 2022
@loginesta
Merge pull request #178 from magento-commerce/imported-loginesta-mage…
8669f85 
…nto-coding-standard-393

[Imported] AC-3098: Update hasDeprecatedWellFormatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted New rule is accepted Progress: good first issue Issues is easy to get started with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lbajsarowicz @ihor-sviziev @lenaorobei