Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Cannot return null for non-nullable field AvailableShippingMethod.method_code when no shipping methods are available #526

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Cannot return null for non-nullable field AvailableShippingMethod.method_code when no shipping methods are available #526

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b78aa2a
Cannot return null for non-nullable field AvailableShippingMethod.met…
XxXgeoXxX Mar 22, 2019
3b48e1d
Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop#524
naydav Apr 23, 2019
cf46fef
GraphQL-526: Cannot return null for non-nullable field AvailableShipp…
naydav Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/code/Magento/QuoteGraphQl/Model/Resolver/ShippingAddress/AvailableShippingMethods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Magento\Framework\Api\ExtensibleDataObjectConverter;
use Magento\Framework\Exception\LocalizedException;
use Magento\Framework\GraphQl\Config\Element\Field;
use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
use Magento\Framework\GraphQl\Query\ResolverInterface;
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
use Magento\Quote\Api\Data\ShippingMethodInterface;
Expand Down Expand Up @@ -65,13 +66,19 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
$shippingRates = $address->getGroupedAllShippingRates();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check this behavior on frontend.
How to frontend work with getGroupedAllShippingRates method and provide the same error message

foreach ($shippingRates as $carrierRates) {
foreach ($carrierRates as $rate) {
$methods[] = $this->dataObjectConverter->toFlatArray(
$method = $this->dataObjectConverter->toFlatArray(
$this->shippingMethodConverter->modelToDataObject($rate, $cart->getQuoteCurrencyCode()),
[],
ShippingMethodInterface::class
);
if ($method['available'] && $method['error_message'] === "") {
$methods[] = $method;
}
}
}
if (count($methods) === 0) {
throw new GraphQlNoSuchEntityException(__(' This shipping method is not available. To use this shipping method, please contact us.'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to load the text of the message from config there

Have no idea how it can be done. So it's a question, not suggestion.

}
return $methods;
}
}