Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Category tree depth calculation issue #100

Closed
dmytro-ch opened this issue Jun 30, 2018 · 4 comments
Closed

Category tree depth calculation issue #100

dmytro-ch opened this issue Jun 30, 2018 · 4 comments
Assignees
@dmytro-ch
Labels
bug Something isn't working Component: CatalogGraphQl small
Milestone
Release: 2.3.1

Comments

@dmytro-ch
Copy link
Contributor

dmytro-ch commented Jun 30, 2018 •
edited
Loading

The maximum level value is being calculated incorrectly.

Preconditions

The result response does not contain the last child item (specified on the deepest level according to the request).
Looks like the issue appears due to the incorrect maximum depth level calculation in \Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider (line 100).

Expected result

screen shot 2018-06-30 at 12 26 38 pm

Actual result

screen shot 2018-06-30 at 12 27 25 pm
@dmytro-ch dmytro-ch self-assigned this Jun 30, 2018
@dmytro-ch dmytro-ch added bug Something isn't working coverage small labels Jun 30, 2018
@dmytro-ch dmytro-ch mentioned this issue Jun 30, 2018
Merged
4 tasks
@mhhansen mhhansen mentioned this issue Jul 12, 2018
Merged
4 tasks
@erikkubica
Copy link

@dmytro-ch as i see for your the category children is working, for some reason for me it´s not i have posted a issue here #123 can you see please anything work with my query?

@naydav
Copy link
Contributor

naydav commented Jul 19, 2018

@erikkubica
Hi, I will check #123 issue

@naydav
Copy link
Contributor

naydav commented Jul 19, 2018

Merged with
#102

@naydav naydav closed this as completed Jul 19, 2018
@paliarush paliarush mentioned this issue Jul 23, 2018
Closed
@naydav naydav reopened this Oct 3, 2018
@naydav naydav closed this as completed Oct 3, 2018
@naydav
Copy link
Contributor

naydav commented Oct 4, 2018

One more PR
#121

@naydav naydav added this to the Release: 2.3.1 milestone Dec 7, 2018
@naydav naydav added the 2.3.1 label Dec 7, 2018
magento-engcom-team pushed a commit that referenced this issue Oct 12, 2019
@kabothu
Merge pull request #100 from magento-arcticfoxes/MC-20337
9360d2a 
Merging MC-20337 to MC-19451 branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmytro-ch dmytro-ch

Labels
bug Something isn't working Component: CatalogGraphQl small
Projects
None yet
Milestone
Release: 2.3.1
Development

No branches or pull requests
3 participants
@naydav @dmytro-ch @erikkubica