#607: Refactored tests for creating empty cart by guests

magento · Apr 16, 2019 · 53b5341 · 53b5341
1 parent 4dd5005
commit 53b5341
Showing 1 changed file with 23 additions and 30 deletions.
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/CreateEmptyCartTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/CreateEmptyCartTest.php
@@ -15,6 +15,7 @@
 use Magento\TestFramework\TestCase\GraphQlAbstract;
 use Magento\Quote\Api\GuestCartRepositoryInterface;
 use Magento\Framework\Math\Random as RandomDataGenerator;
+use Magento\Framework\Exception\LocalizedException;
 
 /**
  * Test for empty cart creation mutation
@@ -105,19 +106,11 @@ public function testCreateEmptyCartWithNotDefaultStore()
     public function testCreateEmptyCartWithCartId()
     {
         $uniqueHash = $this->randomDataGenerator->getUniqueHash();
-
-        $query = <<<QUERY
-mutation {
- createEmptyCart(
-   input : {
-     cart_id : "$uniqueHash"
-   }
- )
-}
-QUERY;
+        $query = $this->getQueryWithCartId('cart_id : "' . $uniqueHash . '"');
         $response = $this->graphQlMutation($query);
 
         self::assertArrayHasKey('createEmptyCart', $response);
+        self::assertNotEmpty($response['createEmptyCart']);
 
         $maskedCartId = $response['createEmptyCart'];
         $guestCart = $this->guestCartRepository->get($maskedCartId);
@@ -137,15 +130,7 @@ public function testValidateCreateEmptyCartWithSpecifiedCartId(string $input, st
         $input = str_replace('provide_non_unique_id', $this->addEmptyCartWithCartId(), $input);
         $input = str_replace('provide_hash_with_prefix', $this->randomDataGenerator->getUniqueHash('prefix'), $input);
 
-        $query = <<<QUERY
-mutation {
- createEmptyCart(
-   input : {
-     {$input}
-   }
- )
-}
-QUERY;
+        $query = $this->getQueryWithCartId($input);
 
         $this->expectExceptionMessage($message);
         $this->graphQlMutation($query);
@@ -163,6 +148,23 @@ private function getQuery(): string
 QUERY;
     }
 
+    /**
+     * @param string $input
+     * @return string
+     */
+    private function getQueryWithCartId(string $input): string
+    {
+        return <<<QUERY
+mutation {
+ createEmptyCart(
+   input : {
+     {$input}
+   }
+ )
+}
+QUERY;
+    }
+
     public function tearDown()
     {
         if (null !== $this->maskedQuoteId) {
@@ -183,21 +185,12 @@ public function tearDown()
      * Return masked id for created empty cart.
      *
      * @return mixed
-     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws LocalizedException
      */
     private function addEmptyCartWithCartId()
     {
         $uniqueHash = $this->randomDataGenerator->getUniqueHash();
-
-        $query = <<<QUERY
-mutation {
- createEmptyCart(
-   input : {
-     cart_id : "$uniqueHash"
-   }
- )
-}
-QUERY;
+        $query = $this->getQueryWithCartId('cart_id : "' . $uniqueHash . '"');
         $response = $this->graphQlMutation($query);
 
         return $response['createEmptyCart'];